GTK3 port and ZIM 0.71#15
Open
gutierri wants to merge 3 commits into
Open
Conversation
|
@gutierri You definetly did better job than me. Great! Using your version now. It works, needs journal plugin enabled and configured correclty. |
domnpp
added a commit
to domnpp/zim-desktop-wiki
that referenced
this pull request
Aug 18, 2019
Osndok/zim-plugin-nowbutton#15 Run configurations, gitgnore for my special setup (make unit tests work, files must be known to git).
domnpp
added a commit
to domnpp/zim-desktop-wiki
that referenced
this pull request
Aug 18, 2019
Osndok/zim-plugin-nowbutton#15 Run configurations, gitgnore for my special setup (make unit tests work, files must be known to git).
Contributor
Author
|
@domenn Great! I am also working on a patch to maintain backward compatibility. This plugin has helped me too. |
Patch zim71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixs: #14 #13 #12
There are some issues with this implementation, such as:
The
Ctrl + Shift + Ekey shortcut does not work and goes into "Read-Only" mode or something like that (But via menu:Tools -> Log Entry, it works). We can change toCtrl + Shift + J.This implementation only works on newer versions. Is keeping compatibility with older versions of ZIM an idea?