Skip to content

Widen transportation, cartography, confidence types to match data #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victor Schappert (vcschapp) merged 2 commits into from
Feb 18, 2026
Merged

Widen transportation, cartography, confidence types to match data #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932f948
Widen transportation types to match data
mojodna Feb 17, 2026
68255b7
Widen cartography and score types
mojodna Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/overture-schema-base-theme/tests/bathymetry_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
},
"sort_key": {
"description": "Integer indicating the recommended order in which to draw features.\n\nFeatures with a lower number should be drawn \"in front\" of features with a higher\nnumber.",
"maximum": 255,
"minimum": 0,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Sort Key",
"type": "integer"
}
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-base-theme/tests/infrastructure_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,8 +624,8 @@
"level": {
"default": 0,
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Level",
"type": "integer"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-base-theme/tests/land_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,8 +499,8 @@
"level": {
"default": 0,
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Level",
"type": "integer"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-base-theme/tests/land_cover_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
},
"sort_key": {
"description": "Integer indicating the recommended order in which to draw features.\n\nFeatures with a lower number should be drawn \"in front\" of features with a higher\nnumber.",
"maximum": 255,
"minimum": 0,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Sort Key",
"type": "integer"
}
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-base-theme/tests/land_use_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,8 @@
"level": {
"default": 0,
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Level",
"type": "integer"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-base-theme/tests/water_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@
"level": {
"default": 0,
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Level",
"type": "integer"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-buildings-theme/tests/building_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,8 +541,8 @@
"level": {
"default": 0,
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Level",
"type": "integer"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-buildings-theme/tests/building_part_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@
"level": {
"default": 0,
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Level",
"type": "integer"
},
Expand Down
10 changes: 5 additions & 5 deletions packages/overture-schema-core/src/overture/schema/core/cartography.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
from pydantic import BaseModel, Field

from overture.schema.system.model_constraint import no_extra_fields
from overture.schema.system.primitive import uint8
from overture.schema.system.primitive import int32

Prominence = NewType(
"Prominence",
Annotated[
uint8,
int32,
Field(
ge=1,
le=100,
Expand All @@ -34,7 +34,7 @@
MinZoom = NewType(
"MinZoom",
Annotated[
uint8,
int32,
Field(
ge=0,
le=23,
Expand All @@ -55,7 +55,7 @@
MaxZoom = NewType(
"MaxZoom",
Annotated[
uint8,
int32,
Field(
ge=0,
le=23,
Expand All @@ -76,7 +76,7 @@
SortKey = NewType(
"SortKey",
Annotated[
uint8,
int32,
Field(
description=textwrap.dedent("""
Integer indicating the recommended order in which to draw features.
Expand Down
10 changes: 5 additions & 5 deletions packages/overture-schema-core/src/overture/schema/core/scoping/vehicle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from overture.schema.core.unit import LengthUnit, WeightUnit
from overture.schema.system.model_constraint import no_extra_fields
from overture.schema.system.primitive import float32, uint8
from overture.schema.system.primitive import float64, uint8


class VehicleDimension(str, Enum):
Expand Down Expand Up @@ -57,7 +57,7 @@ class VehicleHeightSelector(BaseModel):
dimension: Literal[VehicleDimension.HEIGHT]
comparison: VehicleRelation
value: Annotated[
float32,
float64,
Field(
ge=0, description="Vehicle height selection threshold in the given `unit`"
),
Expand All @@ -74,7 +74,7 @@ class VehicleLengthSelector(BaseModel):
dimension: Literal[VehicleDimension.LENGTH]
comparison: VehicleRelation
value: Annotated[
float32,
float64,
Field(
ge=0, description="Vehicle length selection threshold in the given `unit`"
),
Expand All @@ -91,7 +91,7 @@ class VehicleWeightSelector(BaseModel):
dimension: Literal[VehicleDimension.WEIGHT]
comparison: VehicleRelation
value: Annotated[
float32,
float64,
Field(
ge=0, description="Vehicle weight selection threshold in the given `unit`"
),
Expand All @@ -108,7 +108,7 @@ class VehicleWidthSelector(BaseModel):
dimension: Literal[VehicleDimension.WIDTH]
comparison: VehicleRelation
value: Annotated[
float32,
float64,
Field(
ge=0, description="Vehicle width selection threshold in the given `unit`"
),
Expand Down
6 changes: 3 additions & 3 deletions packages/overture-schema-core/src/overture/schema/core/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
Field,
)

from overture.schema.system.primitive import float32, int16, int32
from overture.schema.system.primitive import float64, int32

ConfidenceScore = NewType(
"ConfidenceScore",
Annotated[
float32,
float64,
Field(description="Confidence score between 0.0 and 1.0", ge=0.0, le=1.0),
],
)
Expand All @@ -18,7 +18,7 @@
Level = NewType(
"Level",
Annotated[
int16,
int32,
Field(description="Z-order of the feature where 0 is visual level"),
],
)
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-divisions-theme/tests/division_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
},
"sort_key": {
"description": "Integer indicating the recommended order in which to draw features.\n\nFeatures with a lower number should be drawn \"in front\" of features with a higher\nnumber.",
"maximum": 255,
"minimum": 0,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Sort Key",
"type": "integer"
}
Expand Down
4 changes: 2 additions & 2 deletions packages/overture-schema-transportation-theme/tests/segment_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@
},
"value": {
"description": "Z-order of the feature where 0 is visual level",
"maximum": 32767,
"minimum": -32768,
"maximum": 2147483647,
"minimum": -2147483648,
"title": "Value",
"type": "integer"
}
Expand Down
11 changes: 0 additions & 11 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.