feat: add Dockerfile and CI workflow for Docker image publishing#3
Open
joelgaria wants to merge 1 commit intoPAPAMICA:mainfrom
Open
feat: add Dockerfile and CI workflow for Docker image publishing#3joelgaria wants to merge 1 commit intoPAPAMICA:mainfrom
joelgaria wants to merge 1 commit intoPAPAMICA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds Docker support to make the project deployable on Kubernetes
and other container environments.
Changes
Dockerfile— multi-stage build, non-root user (UID 1001),dumb-init as PID 1, ca-certificates for HTTPS payload fetching
.dockerignore— excludes unnecessary files from the image.github/workflows/docker.yml— builds and pushes multi-archimage (amd64/arm64) to GHCR on every push to main and on tags,
includes Trivy vulnerability scanning
Technical notes
node:22-sliminstead of Alpine: workerd requires glibcwrangler@latestpinned at build time to fix a mkdtemp bug in 4.42.0TMPDIR=/app/.wrangler-tmpto avoid noexec issues on /tmpTested locally on linux/arm64 and linux/amd64.