Skip to content

refactor(http): 重构 HTTP 请求的创建和处理方式#2591

Open
tangge233 wants to merge 10 commits intodevfrom
refactor/request
Open

refactor(http): 重构 HTTP 请求的创建和处理方式#2591
tangge233 wants to merge 10 commits intodevfrom
refactor/request

Conversation

@tangge233
Copy link
Contributor

No description provided.

@pcl-ce-automation pcl-ce-automation bot added 🚧 正在处理 开发人员正在对该内容进行开发、测试或修复,进展中 size: XL PR 大小评估:超大型 labels Mar 11, 2026
@pcl-ce-automation pcl-ce-automation bot added size: XXL PR 大小评估:巨型 and removed size: XL PR 大小评估:超大型 labels Mar 13, 2026
@tangge233 tangge233 marked this pull request as ready for review March 13, 2026 09:23
@pcl-ce-automation pcl-ce-automation bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 and removed 🚧 正在处理 开发人员正在对该内容进行开发、测试或修复,进展中 labels Mar 13, 2026
@LinQingYuu LinQingYuu requested a review from a team March 13, 2026 10:14
Hill23333
Hill23333 previously approved these changes Mar 13, 2026
Copy link
Contributor

@Hill23333 Hill23333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没看

Copy link
Contributor

@ruattd ruattd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我稍微复杂点的网络请求居然还需要写两行 using!

另外,那巨量更改咱要不留个兼容层等以后慢慢改吧,或者 CSharpE 就直接丢了,真没人乐意同步...

@tangge233
Copy link
Contributor Author

我稍微复杂点的网络请求居然还需要写两行 using!

🤔暂时没想出第二行 using 在哪里。目前只要 using PCL.Core.IO.Net.Http.Client.Request; 就能用

@lhx077

This comment was marked as resolved.

lhx077

This comment was marked as resolved.

@lhx077
Copy link
Contributor

lhx077 commented Mar 15, 2026

有一些问题:
第一个是value 允许为空时要不要写 Cookie?目前既有 ThrowIfNullOrEmpty ,后面又有 _GetSafeCookieValue 对空直接 return,感觉有点奇怪

还有一个就是连续两次 ThrowIfNull(value),而 name 未校验,这个是不是应该做修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XXL PR 大小评估:巨型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants