Pre-compute unicode category list for xclasses#647
Draft
zherczeg wants to merge 1 commit intoPCRE2Project:mainfrom
Draft
Pre-compute unicode category list for xclasses#647zherczeg wants to merge 1 commit intoPCRE2Project:mainfrom
zherczeg wants to merge 1 commit intoPCRE2Project:mainfrom
Conversation
Collaborator
Author
|
Note: this patch can wait after the next release. |
Member
|
I like the idea. I'll have to think about it a bit, but it seems OK in principle. Nice idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves a jit optimization to compiler optimization. The unicode categories (there are 30 of them) are combined into a 32 bit bitset, and stored in xclass, instead of a list of properties. This 32 bits, if present, follows the bitset for the first 256 characters. If the value of categories is 0, it is not stored in the xclass.
The patch is working, but the debug (
/B) output is changed for 8-bit ucp case, because the bitset is stored in cranges, and the 8 bit ucp has no cranges.When all 30 category bits are present, the xclass is converted to allany or nothing (negated case).
What do you think about this optimization?