Do not parse if data is already object#16
Open
kanasite wants to merge 2 commits intoPCreations:masterfrom
Open
Do not parse if data is already object#16kanasite wants to merge 2 commits intoPCreations:masterfrom
kanasite wants to merge 2 commits intoPCreations:masterfrom
Conversation
|
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
PCreations
requested changes
Mar 25, 2020
Owner
PCreations
left a comment
PCreations
left a comment
There was a problem hiding this comment.
Good catch ! We might want to add a unit test with a "data" being an object to test this though.
Author
|
@PCreations I'm not very familiar with jest, looking at the existing test case, would you recommend or help with that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PCreations I encountered this error Uncaught SyntaxError: Unexpected token o in JSON at position 1 for certain situation, it turns out that data is already an object hence parsing twice causes the error