-
Notifications
You must be signed in to change notification settings - Fork 0
[WIP] PDOK-18835/vervanging-trex-v2-vertegeling #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DvBree
wants to merge
27
commits into
master
Choose a base branch
from
PDOK-18835/vervanging-trex-v2-vertegeling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2dcf57d
feat: integer polygons with conversion to floating-point
DvBree 8d9ac55
feat: copy pbf encoding functionality from go-spatial
DvBree 6abcd3f
refactor: remove unused parameter in pbf encoding functionality
DvBree f42a4a6
feat: encode polygon in quadrant
DvBree e96c81c
fix: prepare geo instead of just translation
DvBree 9004142
feat: primitive detection of relevant tiles
DvBree a949286
chore: adapt to slippy api change
DvBree d45a6c6
feat: create tables for encoded features
DvBree 3f72663
fix: encode arbitrary geometries
DvBree 995f82b
fix: QBBox returns slice
DvBree 0b60cd9
refactor: decouple geometry logic, logging and channel logic
DvBree fd63764
feat: snap meta-results available during processing
DvBree c2a67cf
fix: create geometry_type field in encodedtable
DvBree ac8917d
feat: types for encoded data
DvBree 13c1944
feat: encoded geometries to database layer
DvBree b462c23
feat: write encoded geometries to target geopackage
DvBree b1057e8
fix: comma in SQL statement
DvBree f4e807b
fix: wrong mix of initialize and append to slice
DvBree ad77fc4
fix: SQL statement syntax error
DvBree 8b52d84
fix: serialize int slice for storage
DvBree e9f1d61
fix: update snap test with new snap return construct
DvBree 29898a2
refactor: moved helper function to geomhelp
DvBree 1dfe343
feat: flag for optional encoding of geometries
DvBree bb69eac
chore: linter warnings (mainly in copied code)
DvBree 5e4c758
refactor: removed unused code
DvBree 7bb1c18
refactor: remove unused function
DvBree 4e07861
test: add PolygonSliceToGeom unit test
DvBree File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package geomhelp | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/go-spatial/geom" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestGeomhelp_PolygonSliceToGeom(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| polygonSlice []geom.Polygon | ||
| want geom.Geometry | ||
| wantPanic bool | ||
| }{ | ||
| { | ||
| name: "Empty polygon slice", | ||
| polygonSlice: []geom.Polygon{}, | ||
| wantPanic: true, | ||
| }, | ||
| { | ||
| name: "Single polygon", | ||
| polygonSlice: []geom.Polygon{{{{0.0, 0.0}, {1.0, 0.0}, {1.0, 1.0}}}}, | ||
| want: geom.Polygon{{{0.0, 0.0}, {1.0, 0.0}, {1.0, 1.0}}}, | ||
| }, | ||
| { | ||
| name: "Two polygons", | ||
| polygonSlice: []geom.Polygon{ | ||
| {{{0.0, 0.0}, {1.0, 0.0}, {1.0, 1.0}}}, | ||
| {{{10.0, 10.0}, {10.0, 11.0}, {11.0, 11.0}}}, | ||
| }, | ||
| want: geom.MultiPolygon{ | ||
| {{{0.0, 0.0}, {1.0, 0.0}, {1.0, 1.0}}}, | ||
| {{{10.0, 10.0}, {10.0, 11.0}, {11.0, 11.0}}}, | ||
| }, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| if tt.wantPanic { | ||
| assert.Panics(t, func() { PolygonSliceToGeom(tt.polygonSlice) }) | ||
| return | ||
| } | ||
| got := PolygonSliceToGeom(tt.polygonSlice) | ||
| assert.Equal(t, tt.want, got) | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*morten