Conversation
…Android into remember-openkeychain-key
LittleFox94
left a comment
LittleFox94
left a comment
There was a problem hiding this comment.
Currently mostly some code style things
|
|
||
| public void doActionOnServerWithFeedback(String action, String server, String keyAPG) { | ||
| String ret = doActionOnServer(action, server, keyAPG); | ||
| public void doActionOnServerWithFeedback(String action, String server, String keyAPG, String openPGPKey) { |
There was a problem hiding this comment.
please rename to openPGPKeyID everywhere
This way its is clearer what that variable is ^^
| String _name; | ||
| String _url; | ||
| String _apgKey; | ||
| String _openpgpgKey; |
There was a problem hiding this comment.
pgpg? Looks like a nice combination of PGP and GPG, but please only use one ^^
I would prefer PGP
There was a problem hiding this comment.
Can you reuse apgKey? (did we have that question before :O )
|
|
||
| if (parts.length == 3) { | ||
| return new Server(parts[0], parts[1], parts[2]); | ||
| if (parts.length == 5) { |
There was a problem hiding this comment.
do not change things in this function. It is only here to support config loading for configs generated by older versions of the app
| ret.put("name", _name); | ||
| ret.put("url", _url); | ||
| ret.put("apgKey", _apgKey); | ||
| if (saveKey()) { |
There was a problem hiding this comment.
use private variables where possible, as function calls are slower in most languages.
|
But thank you very much for your changes :) |
2 participants
Initial Work for #19
What do you think @LittleFox94 ?