Skip to content

Comments

fix: invalid string escapes now correctly report errors#1607

Open
mhasel wants to merge 4 commits intomasterfrom
mihr/fix-string-escapes
Open

fix: invalid string escapes now correctly report errors#1607
mhasel wants to merge 4 commits intomasterfrom
mihr/fix-string-escapes

Conversation

@mhasel
Copy link
Member

@mhasel mhasel commented Feb 20, 2026

Changes the literal string parsing from a double-processed regex parsing to a linear left-to-right parsing approach.
This fixes both #1593 and #1601

Enables skipped tests introduced by #1603

@mhasel mhasel marked this pull request as ready for review February 20, 2026 14:45
@mhasel mhasel requested review from ghaith and volsa February 20, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle_special_chars double-processes $$ followed by hex digits Invalid string literal escape sequences should err

1 participant