Bot test: Global variable comparison#17
Open
PLukas2018 wants to merge 4 commits into
Open
Conversation
Owner
Author
|
\evaluate |
EqBench
DetailsDetails for default optimizationDetails for default optimizationDetails for -O2 optimizationDetails for -O2 optimization |
RHEL functions
Details |
RHEL sysctl
DetailsDetails for 8.0-8.1Details for 8.0-8.1Details for 8.1-8.2Details for 8.1-8.2Details for 8.2-8.3Details for 8.2-8.3Details for 8.3-8.4Details for 8.3-8.4Details for 8.4-8.5Details for 8.4-8.5 |
Owner
Author
|
\evaluate --rebuild |
This fixes the issue of ninja crashing when building using nix flakes, when z3 is installed on the system, by prioritizing FindZ3 script before falling back to Z3Config.
EqBench
DetailsDetails for default optimizationDetails for default optimizationDetails for -O2 optimizationDetails for -O2 optimization |
RHEL functions
Details |
RHEL sysctl
DetailsDetails for 8.0-8.1Details for 8.0-8.1Details for 8.1-8.2Details for 8.1-8.2Details for 8.2-8.3Details for 8.2-8.3Details for 8.3-8.4Details for 8.3-8.4Details for 8.4-8.5Details for 8.4-8.5 |
9761afe to
3bec8a2
Compare
Owner
Author
|
\evaluate --rebuild |
EqBench
DetailsDetails for default optimizationDetails for default optimizationDetails for -O2 optimizationDetails for -O2 optimization |
RHEL functions
Details |
RHEL sysctl
DetailsDetails for 8.0-8.1Details for 8.0-8.1Details for 8.1-8.2Details for 8.1-8.2Details for 8.2-8.3Details for 8.2-8.3Details for 8.3-8.4Details for 8.3-8.4Details for 8.4-8.5Details for 8.4-8.5 |
3bec8a2 to
245ab69
Compare
Owner
Author
|
\evaluate --rebuild |
1 similar comment
Owner
Author
|
\evaluate --rebuild |
EqBench
DetailsDetails for default optimizationDetails for default optimizationDetails for -O2 optimizationDetails for -O2 optimization |
RHEL functions
DetailsDetails for 8.0-8.1Details for 8.0-8.1Details for 8.1-8.2Details for 8.1-8.2Details for 8.2-8.3Details for 8.2-8.3Details for 8.3-8.4Details for 8.3-8.4Details for 8.4-8.5Details for 8.4-8.5 |
RHEL sysctl
DetailsDetails for 8.0-8.1Details for 8.0-8.1Details for 8.1-8.2Details for 8.1-8.2Compared symbols newly evaluated as non-equal
Details for 8.2-8.3Details for 8.2-8.3Details for 8.3-8.4Details for 8.3-8.4Compared symbols previously evaluated as non-equal
Eliminated differing symbols
Details for 8.4-8.5Details for 8.4-8.5Eliminated differing symbols
|
If a global variable is present in the symbol list during function comparison, a group of all functions using this global variable is created, similarly how sysctl comparison is treated. In this case, the overall Result (root of the Result tree) can contain both functions and function groups. Group_kind field was also added to Result so it is possible to distinguish between different kinds of groups, e.g. sysctl and glob_var.
The result viewer was changed to handle different shapes of the result comparison tree. The viewer displays differences in the same way as before the change, that is it only shows the differences found in functions, not how these functions are aggregated in groups.
A few tests were added to test whether the result viewer can handle different shapes of the result comparison tree.
245ab69 to
a5aa151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.