Fixed welded links, tracer points in welded links, and added circular links for grounded joints#306
Merged
Merged
Conversation
…th in svg-path.service
…o both two joint links and compound links. Does not handle intersections yet
… and helper functions line/circle and circle/circle
…tion points and remove them
…s they belong to and split each arc and line by their intersection points
…d fixed them. Added checks to add back in duplicate lines if there is a gap, as well as remove short lines. Still debugging
…tersection points were being returned
…ecause the same exact coordinates was giving a distance > 0.0001
…use it was throwing off the check for whether a segment was within a link
…s tangent and angles for point within an arc
… intersection and then remove that point
… completed. This fixed issue with welding when two links were welded and one link had a length of virtually 0
…t in wrong direction. Made sure that intersection points were sorted in order of how close they are to the arc start position
…ons is automatically deleted. Now, it calculates the outline correctly
…r point add in compound link for visual shape of tracer point
… add a tracer point to that underlying link for welded links
… trajectory component from graph component
…d if the link does not have an input joint
…rns link into circular link
…sue of circle not forming for any bar besides first created
… first one and issue with tracer points for circular links
…on about the compound link, links, and joints being deleted
…builds the joints, links, and compound link that was deleted
…cer points for welded links
…oint a ground joint
✅ Deploy Preview for steady-macaron-f82663 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for pmks failed.
|
…of prevJointData to match JointSnapshot
…r-links-with-delete-welded-link
…d. Now they are created
…r-links-with-delete-welded-link
rkprad
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the fix for welded links, changing the visuals of tracer points and fixing how they are added and deleted in welded links. This also contains the addition of circular links for any grounded joints.