Skip to content

Bug/#118 119 120 팀조회권한 트랙조회검증 대회이름중복 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myeowon merged 3 commits into from
Apr 9, 2026
Merged

Bug/#118 119 120 팀조회권한 트랙조회검증 대회이름중복 #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fff072a
feat : 회원용 팀 조회 API 호출 시 ROLE_관리자 권한 검증 추가
myeowon Mar 30, 2026
3387d39
feat : 유효하지 않은 contestId로 트랙 조회 요청 시 예외 처리
myeowon Mar 30, 2026
cbc74b1
fix : 대회 수정 시 동일한 대회명에 대한 중복 검증 제외
myeowon Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/com/opus/opus/modules/contest/application/ContestCommandService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,13 @@ public ContestResponse createContest(final ContestRequest request) {
}

public void updateContest(final Long contestId, final ContestRequest request) {
contestConvenience.validateDuplicateContestName(request.contestName());
contestCategoryConvenience.getValidateExistCategory(request.categoryId());
final Contest contest = contestConvenience.getValidateExistContest(contestId);
contestCategoryConvenience.getValidateExistCategory(request.categoryId());

if (!contest.getContestName().equals(request.contestName())) {
contestConvenience.validateDuplicateContestName(request.contestName());
}

contest.updateContest(request.categoryId(), request.contestName());
}

Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/opus/opus/modules/contest/application/ContestTrackQueryService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.opus.opus.modules.contest.application;

import com.opus.opus.modules.contest.application.convenience.ContestConvenience;
import com.opus.opus.modules.contest.application.dto.response.ContestTrackResponse;
import com.opus.opus.modules.contest.domain.ContestTrack;
import com.opus.opus.modules.contest.domain.dao.ContestTrackRepository;
Expand All @@ -14,8 +15,10 @@
public class ContestTrackQueryService {

private final ContestTrackRepository contestTrackRepository;
private final ContestConvenience contestConvenience;

public List<ContestTrackResponse> getAllContestTracks(final Long contestId) {
contestConvenience.getValidateExistContest(contestId);
final List<ContestTrack> contestTracks = contestTrackRepository.findAllByContestId(contestId);
return contestTracks.stream()
.map(ContestTrackResponse::from)
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/com/opus/opus/modules/contest/domain/dao/ContestTrackRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@

import com.opus.opus.modules.contest.domain.ContestTrack;
import java.util.List;
import java.util.Optional;
import org.springframework.data.jpa.repository.JpaRepository;

public interface ContestTrackRepository extends JpaRepository<ContestTrack, Long> {
boolean existsByContestIdAndTrackName(final Long contestId, final String trackName);

Optional<ContestTrack> findByIdAndContestId(final Long trackId, final Long contestId);

List<ContestTrack> findAllByContestId(final Long contestId);
}
2 changes: 1 addition & 1 deletion src/main/java/com/opus/opus/modules/team/api/TeamController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public ResponseEntity<Void> deleteTeam(@PathVariable final Long teamId) {
return ResponseEntity.noContent().build();
}

@Secured("ROLE_회원")
@Secured({"ROLE_회원", "ROLE_관리자"})
@GetMapping("/{teamId}")
public ResponseEntity<TeamDetailResponse> getTeamDetail(@PathVariable final Long teamId,
@LoginMember final Member member) {
Expand Down