fix: 라이브 하이퍼바이저 조회의 실패 경로 정정 - #43
Merged
Merged
Conversation
The usage series and the system panel's live node block each turned a recoverable refusal into the wrong answer. An unconfigured API token makes the client refuse before the request leaves, and only the transport exception was caught, so a state the configuration explicitly permits produced a 500 instead of the designed 503. On the node block, the storage probe shared a try with the status probe, so losing the storage read right alone discarded a successful status read and reported the node as not answering; the two probes are now separate answers and a null status envelope reads as unreachable rather than dereferencing past the catch. A node the operator marked OFFLINE is no longer probed at all, matching the status poller, and keeps its row so the node count stays whole. RRD rows without a timestamp are dropped where the series is mapped, since the contract makes that field required and a point with no place on the axis cannot be charted. The three reads also no longer run inside a read-only transaction. Each held a pooled database connection for the whole Proxmox call, up to the client read timeout, so a stalled pveproxy plus a refreshing dashboard could drain the pool and take unrelated endpoints down with it. The boundary is safe because nothing here needs one transaction: every access lookup, repository call and collaborator carries its own, the summary's tiles are independent counters, and the entities read afterwards are touched on basic columns only, so no lazy association is left outside a transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업내용
⭐️ 검증
💬 리뷰 포인트