refactor: 접근 권한 규칙을 종류에서 떼어내기 - #45
Merged
Merged
Conversation
The access list is keyed by resource type already, but everything that reads it is written against the VM entity. These are the pieces the shared write side needs: what a grant is worth (one resolver, one standing), and the per-type words and audit names that are the only part a second resource type may legitimately answer differently.
Grant, revoke, list, the cap on workspace-wide grants, the grantee eligibility rule and the break-glass boundary now live in one service that names no resource type. What a type still answers for itself is loading the thing, which workspace owns it, what its limited view shows and the sentences it refuses in, all through its existing adapter. The VM controller keeps its paths and its bodies unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업내용
⭐️ 검증
💬 리뷰 포인트