fix: 모니터링 화면의 측정 불가 상태 처리 정정 - #25
Merged
Merged
Conversation
An unreachable hypervisor answered 503 and every usage surface turned it into a red alert that retried forever, while the admin dashboard already rendered the same condition as a calm tile. The two screens now agree: an offline node is never polled, an unreadable hypervisor is stated plainly and stops re-asking, and a deleting VM no longer offers a usage tab. Byte axes pick the closest 1-2-5 step instead of always rounding up, so a 78 GiB memory axis is labelled to its top (0 B through 80.0 GiB) rather than stopping at 50.0 GiB, and isolated samples now draw a point so a mostly-stopped guest no longer looks like broken monitoring. Verified in a headless chromium render: a two-sample gappy series painted 0 series pixels before and 48 after. Allocation summaries read the whole window, so a there-and-back change is no longer reported as no change, and the over-provisioned disk pool shows its true ratio without the hard-limit warning colours.
The collapsible table under every chart is gone, and with it TABLE_ROWS and sampledIndexes so no dead code is left behind. The technical captions go too: how a percentage is defined, where a memory figure comes from, and what an empty stretch means are not things a student needs. What stays is what it takes to read the screen: axis, legend, value format, the last-updated time, and the state notices for missing or unreadable data. Charts are now the only window on the values, so the chart area carries its title as its accessible name. Removing the table also takes away the DOM the screen tests read values from, so the data preparation those tests covered indirectly is now covered directly as pure functions (series extraction, gap handling, axis ticks, summary sentences) and the screen tests assert state branches and accessible labels instead. Confirmed in a headless chromium render that this leaves no silently empty chart: a 60 point hour where a mostly stopped guest reported three isolated samples painted 0 series pixels before the point fix and 69 after, one dot per sample. The admin node screen's tab and section now read 할당 추이, matching the org dashboard card, per the operator's terminology decision. The tab id stays 'trend' so existing links keep opening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업내용
⭐️ 검증
💬 리뷰 포인트