Open
Conversation
Reworked arrow task such that it will now simply wait for the task to be complete for the first time and then move forward. This stops CheckArrowTask() from being called again later and restarting the coroutine as was happening with the bug.
Removed the CheckArrowTask() script from the Directional Arrows as they do not need to call this anymore. It is now taken care of by the Wait Until statement in the scene manager.
Added APK file for testing this bugfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This task is a bugfix in response to the GitHub Issue: #91. The cause of this issue is that the directional arrows in Scene 2 continuously call the function CheckArrowTask() which starts the next coroutine when the directional arrows have been pointed correctly. This function can still be called after initial completion by undoing and recompleting the task, restarting the coroutine and giving the appearance of overlaying audio. A video of this effect is found here: https://drive.google.com/file/d/1WJt6KGXown9MXiG5lTWtymnX1kLYldfz/view?usp=sharing
Fix:
Something To Think About: