improved mostly step merged with merger object (especially WD mergers)…#311
improved mostly step merged with merger object (especially WD mergers)…#311ezapartas wants to merge 8 commits intodevelopment-deprecatedfrom
Conversation
…), merger center value calcualtion and allowing co_core_mass in detached
…or avg_c_in_c_core) is np.nan to return np.nan
|
@dimsour94 and @kasdaglie should review this PR. @ezapartas has been using it and expects no issues. |
|
Update (July 25): Need to merge latest updates from development into this PR. Needs to be checked again by Manos. |
…into manos_better_WDmergers_treatment
dimsour94
left a comment
There was a problem hiding this comment.
Tested and operating well.
|
Update (Aug 1): It looks like this code fixes the problem, but we need to be careful about the use of copy.deepcopy(star), as it may bloat the memory usage. @ezapartas and @dimsour94 to meet with @ka-rocha to check memory usage and see if either: it is fine with deep copy or if there is another way to perform the calculations. |
|
Update (Aug 29): Still holding off on this - we are opting for a different solution, where we don't rely on a copy command. |
…into manos_better_WDmergers_treatment
|
Update (Sept 19): @dimsour94 to check with @ka-rocha and @ezapartas about the status of this code change. Will it cause any unintended consequences? |
…into manos_better_WDmergers_treatment
|
Update Sep 24: After discussing with @ka-rocha we decided to go with the solution of not creating or copying a new star object for the merged product. So firstly use the previous |
…), merger center value calculation and allowing co_core_mass in detached