-
Notifications
You must be signed in to change notification settings - Fork 30
[enhancement] Clean POSYDON repository #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxbriel
wants to merge
352
commits into
main
Choose a base branch
from
mb_update_repo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
352 commits
Select commit
Hold shift + click to select a range
d51fbe4
Delete dev-tools/outputs/baseline.h5
elizabethteng 6301581
add readme
elizabethteng 22102ea
Update README.md
elizabethteng d0eaf91
Update README.md
elizabethteng 4c96435
Create validate_binaries.sh
elizabethteng 73e1465
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ebc2c86
Create dummy file baseline.h5
elizabethteng e416fc8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 47a0d37
outline script
elizabethteng ed95ed7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 578cd4c
Modify evolve_binaries.sh for saved output and logs in folder outputs
elizabethteng e4908e0
Modify evolve_binary for HDF5 output and error handling
elizabethteng dc65854
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8a0d5ba
Update 1Zsun_binaries_suite.py to fix args in function calls
elizabethteng 9da430d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7a3bd52
Update authors
elizabethteng 02d10a2
remove alarm calls that were never set
elizabethteng 5cbf4ba
Enhance evolve_binaries.sh for better logging and error handling
elizabethteng 621be97
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c3256b5
Fix argument passing for evolve_binaries function
elizabethteng e4dedbe
fill in all code for validate_binaries.sh
elizabethteng d66cf6e
starting point of compare_runs.py for comparing two h5 files
elizabethteng 46cdc5a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b89ff37
Add conda source detection in evolve_binaries.sh
elizabethteng 1529d76
Add h5py import to 1Zsun_binaries_suite.py
elizabethteng 7cb3922
refactor binary validation suite: multi metallicity support, bug fixe…
elizabethteng 06abf4b
gitignore
elizabethteng d80800b
adding baseline h5 file for binary evolution
elizabethteng 4fadb6f
add tolerances as CLI
elizabethteng d3d29c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 57e13ed
separate handling of errored binaries from successful binaries into a…
elizabethteng ea43593
consolidate h5 writes for efficiency
elizabethteng f080770
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 435013f
add flag to promote existing evolved branch to baseline status
elizabethteng 6474dea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e157c01
Move binaries_suite.py and binaries_params.ini to dev-tools root
elizabethteng 5357e0b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 545db6c
Delete dev-tools/outputs/baseline.h5
elizabethteng 17b9839
add readme
elizabethteng 2ee28f9
Update README.md
elizabethteng 74ae017
Update README.md
elizabethteng a254306
minor change
elizabethteng d8e6138
minor change
elizabethteng c9b265c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d95c17a
remove rebase artifacts
elizabethteng 108e34c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fffba17
bug fix
elizabethteng 421274e
Merge branch 'et-validation' of https://github.com/POSYDON-code/POSYD…
elizabethteng 0331232
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 003530a
create GRIDInterpolators once in SimulationProperties when loading st…
sgossage 8f1d5e1
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage 5f820e6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 12759fb
cleaning
sgossage 62c53ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4605e8a
only delete GRIDInterpolator objects if they exist
sgossage 1184acb
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage 8f3fc0e
remove @profile tag
sgossage bc21fa6
cleaning
sgossage 3fb820f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3fe62d7
check/create GRIDInterpolators for each metallicity
sgossage 83af345
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d1f7f7e
cleaning and compartmentalizing functions in load_a_step, esp. for Tr…
sgossage 66725e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 22b08cf
move track_matcher.py to binary_evol
sgossage 6b2c499
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 50dff99
removing TrackMatcher kwargs from step __init__ methods. These are se…
sgossage e5186d8
add list_for_matching for step_merged to default ini file so that it …
sgossage fe10943
Update validate_binaries.sh to add guidance about tolerances
elizabethteng a4fa52c
Update README.md to add guidance about tolerances
elizabethteng e6ae3c2
Update README.md
elizabethteng 23d78ac
properly close PSyGrids per metallicity
sgossage 85761a0
Update posydon/popsyn/distributions.py
maxbriel 6ff9c7f
Merge branch 'v2.3' into mb_initial_conditions_sampling
maxbriel 80c4410
remove unused import
maxbriel 1f7a56b
make lower q boundary exclusive
maxbriel 9f7ac48
move comment into doc string + expand description
maxbriel 389b8d2
[fix] Variable assignment for binary star example (#813)
maxbriel 7fd0ce3
[fix] Typo culmulative to cumulative (#820)
maxbriel 2e1e89d
add units to model weights function docstrings
maxbriel d204b62
Merge branch 'main' of github.com:POSYDON-code/POSYDON
sgossage 424afc1
better separation of TrackMatcher and step handling
sgossage 52fd63d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c8cbfab
adding doc strings in simulationproperties.py
sgossage 817d64c
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage 0379b2b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] eba4bac
docstring for LazyHDF5 class
sgossage 19b7f70
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage 7d7bcbf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 430603d
replace a potentially deprecated line that forced self.steps_loaded =…
sgossage 55145e7
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage b440e92
update doc strings in step_detached.py
sgossage c5a7fc1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7c722f8
add kwarg assignment to step_mesa, similar to how it is done in other…
sgossage c98845d
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage 453b05b
giving all evolution classes DEFAULT_KWARGS, which holds their defaul…
sgossage 5f97ff3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 67265ef
remove ignore_for_met and list contianing steps that need TrackMatche…
sgossage e8a7564
Merge branch 'sg_v2.3_fix_ram_usage' of github.com:POSYDON-code/POSYD…
sgossage f06b299
Adding an RNG kwarg to load_steps() and load_a_step() in simulationpr…
sgossage 3f78229
change is not to != and update __repr__ for StepSN
sgossage 85bfa7e
use __dict__ to print all attributes of StepSN in __repr__
sgossage 003060a
use __dict__ to print all attributes of StepSN in __repr__
sgossage 28e6af9
Update binaries_suite.py to save path_to_posydon_data in the H5 metadata
elizabethteng 0bab574
Update generate_baseline.sh to save PATH_TO_POSYDON_DATA to baseline_…
elizabethteng b1f5166
Update binaries_suite.py to check how many binaries ran and save to m…
elizabethteng f2e9361
Update generate_baseline.sh to check if any binaries didn't run
elizabethteng 5c505c8
Update compare_runs.py to eliminate redundancies in report (missing b…
elizabethteng 2963bdf
Merge branch 'main' into v2.3
maxbriel b24ee24
Merge branch 'v2.3' into mb_initial_conditions_sampling
maxbriel e1e2213
change description
maxbriel b47dd21
Merge remote-tracking branch 'origin/v2.3' into et-validation
elizabethteng 64be558
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d0555a4
added more descriptive errors to evolve_binaries
elizabethteng 7d3290f
Merge branch 'et-validation' of https://github.com/POSYDON-code/POSYD…
elizabethteng 5f57b85
Merge branch 'v2.3' into sg_v2.3_fix_ram_usage
sgossage b9e823a
Merge branch 'v2.3' into sg_v2.3_rng_for_steps
sgossage c604093
pass RNG down to bondi_hoyle accretion functions in step_mesa and ste…
sgossage 00c257c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5ced319
add RNG argument for SimulationProperties.from_ini that may be used t…
sgossage daec081
Merge branch 'sg_v2.3_rng_for_steps' of github.com:POSYDON-code/POSYD…
sgossage 8cfb9bc
update bondi_hoyle unit test
sgossage d785905
move key_library.py from posydon/binary_evol/DT to posydon/utils
sgossage d2d3f84
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 42374a3
Merge branch 'sg_v2.3_fix_ram_usage' into sg_v2.3_rng_for_steps
sgossage 8e267c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6457eed
Merge branch 'main' of github.com:POSYDON-code/POSYDON
sgossage 247ef50
Rebase popsyn unit tests onto v2.3
elizabethteng 1c9bda5
population helper function
elizabethteng 9527e7c
Refactor test_synthetic_population to use make_test_pop helper
elizabethteng 30bcbcf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cc63eaf
fix failing tests
elizabethteng af54106
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0e89d23
Merge pull request #797 from POSYDON-code/mb_initial_conditions_sampling
astroJeff a97e18b
Update setup.cfg to exclude analysis.py and GRB.py from testing
elizabethteng 00ff3e8
Merge pull request #818 from POSYDON-code/sg_v2.3_fix_ram_usage
astroJeff e85ff24
removed tests for inactive code
elizabethteng 904ac5c
Merge branch 'et_unittest_popsyn' of https://github.com/POSYDON-code/…
elizabethteng 4f604c1
add note about being omitted from testing
elizabethteng ec77dea
Merge branch 'v2.3' into et_unittest_popsyn
elizabethteng 1c50d14
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 111225a
Merge branch 'v2.3' into sg_v2.3_rng_for_steps
sgossage 02cd07d
Merge pull request #826 from POSYDON-code/sg_v2.3_rng_for_steps
astroJeff b989bf6
Merge branch 'main' of github.com:POSYDON-code/POSYDON
sgossage 81b03ca
Merge branch 'main' into v2.3
sgossage b25e22f
add [grid_paths] section to .ini file and link settings to MESA grid …
sgossage 9babcf0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 101da5c
only check path existence if a custom path provided
sgossage 559caec
Merge branch 'sg_v2.3_gpaths_in_ini' of github.com:POSYDON-code/POSYD…
sgossage 27253e5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7653a32
disabling path validity check for unit test
sgossage eb9e619
Merge branch 'sg_v2.3_gpaths_in_ini' of github.com:POSYDON-code/POSYD…
sgossage 22492a4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3475da5
add doc string to SimulationProperties.set_path() and delete the path…
sgossage 5e2d126
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 81abcd1
merge + add list
maxbriel b7987c9
Remove added model after merge
maxbriel 4cb4ac7
Merge branch 'v2.3' into mb_add_docs_model_weight
maxbriel 9ec2752
add additional info on types of info in dict
maxbriel 5e87ee2
updated for change from metallicity to metallicities
elizabethteng 7b75f9f
updated coverage
elizabethteng 08c42b3
update test coverage
elizabethteng a8481aa
finishing tests for synthetic_population
elizabethteng a7246a6
fix small issue with rates helper function
elizabethteng 6fa63f6
finish coverage of synthetic population test
elizabethteng a2d2dea
cleaning up annoying warnings
elizabethteng 79444d7
update to remove tests for things that have been removed
elizabethteng 063a5c3
update independent_sample test to reflect changes to distributions, a…
elizabethteng 9422a5f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fe0aad6
change author to authors
elizabethteng 08528e6
update test for io.py
elizabethteng c8953ec
unit test for sample_from_file
elizabethteng 7183c04
updated transient_select_funcs tests to add a new one for new funcito…
elizabethteng cfb4493
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c2bfaab
Update continuous_integration.yml to cover all of popsyn
elizabethteng 152abaa
update defaults for multiple metallicities being in list form
elizabethteng b77d96f
debug tests
elizabethteng fb0ea07
fix bug in conditional statement
elizabethteng e0f8c61
clean up coverage of branches
elizabethteng cbb02b5
add coverage
elizabethteng 64856a1
Merge branch 'et_unittest_popsyn' of https://github.com/POSYDON-code/…
elizabethteng 773037e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 74861af
moved coverage addition to correct location
elizabethteng 0f4ecec
format
elizabethteng ef8fed4
get rid of isclass, isroutine imports -- no longer necessary
elizabethteng 24f36bc
add test for selection effects
elizabethteng d6e7e5a
merge
elizabethteng 6975dfc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5467494
write tests for Moes_distributions.py
elizabethteng a6695db
fix bug and update coverage
elizabethteng 72bd2e9
fix bug and update coverage
elizabethteng 013a7cc
remove isroutine checks
elizabethteng 89bedc9
update coverage
elizabethteng d0a98fb
Merge branch 'et_unittest_popsyn' of https://github.com/POSYDON-code/…
elizabethteng 9232de2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f865de8
Update continuous_integration.yml
elizabethteng 9c5c45b
restore test I accidentally deleted
elizabethteng 28be49d
fix mistake from merge
elizabethteng baff2c1
Merge branch 'et_unittest_popsyn' of https://github.com/POSYDON-code/…
elizabethteng fc9d205
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9547b8c
first draft of binarypopulation test
elizabethteng bf60169
mock out dependence on external data file
elizabethteng 0b5bdb4
Merge branch 'et_unittest_popsyn' of https://github.com/POSYDON-code/…
elizabethteng 0706981
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3200c54
adjust coverage for binarypopulation
elizabethteng 60224de
debug tests and adjust coverage
elizabethteng c572068
fix merge conflict
elizabethteng 9936534
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5902f3c
Apply suggestion from @sgossage -- indent dummy_code
sgossage fef6715
Apply suggestion from @sgossage
sgossage 71688ae
Apply suggestion from @sgossage
sgossage 530f12c
Apply suggestion from @sgossage -- fix indent
sgossage b0382d7
Apply suggestion from @sgossage -- remove alt code
sgossage d4fceb0
Apply suggestion from @sgossage -- fix indent
sgossage dc1bd2b
Apply suggestion from @sgossage - fix indent
sgossage e4a60eb
Adding ini_path back to test_io.py
sgossage 3528041
Update posydon/unit_tests/_helper_functions_for_tests/population.py
elizabethteng 21082c8
revert change to population.py
elizabethteng c71f929
Refactor ini and dummy code content in test_io.py using dedent
sgossage 7d4608e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e98f569
Fix indent test_io.py
sgossage d4cf906
Remove extra quote in test_io.py
sgossage 9058f40
added option to skip evolution in validate_binaries, added info about…
elizabethteng ff2294f
updated README with more in-depth information that may be useful for …
elizabethteng 322d05e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d02aa9a
add note about RNG reproducibility fix by Seth's PR
elizabethteng 3d9fb8e
Merge branch 'et-validation' of https://github.com/POSYDON-code/POSYD…
elizabethteng dd4e0bb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7799b8e
Update dev-tools/README.md
elizabethteng bd616e9
Update dev-tools/README.md
elizabethteng a7ad842
Update dev-tools/README.md
elizabethteng ba4ac8a
Update dev-tools/README.md
elizabethteng 03c1b4a
added more details about --promote option
elizabethteng b36f237
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d715e96
Remove metallicity print statement
sgossage 0f6197f
Merge pull request #821 from POSYDON-code/mb_stepCE_docstring
astroJeff e793c16
Merge pull request #823 from POSYDON-code/mb_add_docs_model_weight
astroJeff a5722ea
Merge pull request #780 from POSYDON-code/et-validation
astroJeff 09e6f1f
Merge pull request #831 from POSYDON-code/sg_v2.3_gpaths_in_ini
astroJeff a2a230a
Merge pull request #499 from POSYDON-code/et_unittest_popsyn
astroJeff 32010e9
Merge branch 'main' into mb_update_repo
sgossage ff97240
Update package version to use GIT_DESCRIBE_TAG
sgossage 1c97a65
[fix] add test for failing unit tests (`[grid_path]` + symlink) (#835)
maxbriel 0de835f
[fix/feat] Remove duplicate functions in `grid_utils` (#815)
maxbriel b81d2df
[v2.3] Add `to_df()` method for `LazyHDF5` (#836)
sgossage 09ef8e4
Merge branch 'v2.3' into mb_update_repo
sgossage 18443d6
Revert "Merge branch 'v2.3' into mb_update_repo"
sgossage d509af2
ignore docs/_source/_build/ directory
sgossage f615d41
fixing inconsitent tab indent in compress_mesa_files.py and trying to…
sgossage dd7935b
remove debug, add comment
sgossage 62b0924
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,3 @@ | ||
| [submodule "grid_params/POSYDON-MESA-INLISTS"] | ||
| path = grid_params/POSYDON-MESA-INLISTS | ||
| url = https://github.com/POSYDON-code/POSYDON-MESA-INLISTS.git | ||
| [submodule "data/POSYDON_data"] | ||
| path = data/POSYDON_data | ||
| url = https://github.com/POSYDON-code/POSYDON_data.git | ||
| [submodule "posydon/tests/data/POSYDON-UNIT-TESTS"] | ||
| path = posydon/tests/data/POSYDON-UNIT-TESTS | ||
| url = https://github.com/POSYDON-code/POSYDON-UNIT-TESTS.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| {% set name = "posydon" %} | ||
| {% set version = "2.2.8" %} | ||
|
|
||
| package: | ||
| name: "{{ name|lower }}" | ||
| version: "{{ version }}" | ||
| version: {{ GIT_DESCRIBE_TAG }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minor stylistic suggestion: leave the quotes on
|
||
|
|
||
| source: | ||
| path: .. | ||
|
|
@@ -17,7 +16,8 @@ requirements: | |
| host: | ||
| - pip | ||
| - python==3.11 | ||
| - setuptools>=38.2.5 | ||
| - setuptools>=76.0.0 | ||
| - setuptools-scm>=8.0 | ||
|
|
||
| run: | ||
| - python==3.11 | ||
|
|
||
Submodule POSYDON_data
deleted from
e5d8d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert to the old
version: "{{ version }}"?Otherwise I think we can test if this works for us with a release after merging.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem to be working well. In my local test of
publish_conda, the tagv2.2.4gets picked up, I think because that is the latest tag this branch can grab.