Conversation
…glestar object as scalar
for more information, see https://pre-commit.ci
| m_rem = star.mass | ||
| else: | ||
| m_rem = star.he_core_mass | ||
| f_fb = 0.99 |
There was a problem hiding this comment.
Are this one and the state not supposed to be set in the context of conserve_hydrogen_envelope too?
There was a problem hiding this comment.
Same in the other sections of conserve_hydrogen_envelope
|
|
||
| return m_rem, f_fb, state | ||
|
|
||
| def Maltsev25_corecollapse(self, star, engine, conserve_hydrogen_envelope=False): |
There was a problem hiding this comment.
@astroJeff @sgossage I'm starting to feel that the step_SN file is becoming quite large. I think it's time to split this into separate files.
@ezapartas Nothing for you to do on this comment.
for more information, see https://pre-commit.ci
dimsour94
left a comment
dimsour94
left a comment
There was a problem hiding this comment.
I ran a population of 5,000 systems using this branch, including the Maltsev central entropy file with nearest-neighbour and interp_values set to False, and it worked well. The only remaining open issue is the treatment of SNe forming fallback BHs: we currently assume a fallback fraction of 0.99, but we still need to determine what the appropriate fallback fraction should be.
3 participants
Implementing Maltsev explodablity criterion:
As an alternative to Patton20+Ertl16 criterion, now we have Patton20+Maltsev25 criterion
For now, implementation only for M_CO <= 10 Msun (as in Patton20+Ertl16 criterion). Still needed to implement the case for M_CO > 10 Msun (where the MT history is needed right now).
To work it still needs: