[enhancement] Refactor of independent_sampling.py#797
Open
[enhancement] Refactor of independent_sampling.py#797
independent_sampling.py#797Conversation
independent_sampling.pyindependent_sampling.py
Collaborator
Author
|
Here are distributions. I ran it on the v2.3 branch and this branch. I didn't see any major differences between the distributions. population_synthesis_analysis_v2.3.pdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors
independent_samplingto use thedistributionsandIMFsfor sampling.This additionally adds:
inverse_samplerandrejection_samplerI have tested this within the context of the unit tests. Not within initial population sampling. However, the norm_pop unit tests contain quite a few tests where the initial samplers are used. These seem to function similarly to before.
This PR does not make any functional changes.
This is the first step to solving issues related the initial sampling, including the difference between setting$m_2$ or $q$ boundaries.