[enhancement] Synthetic population lazy imports#798
Open
Conversation
maxbriel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importing from the synthetic population file often took longer than a few seconds, when loading for the first time
i.e.
from posydon.popsyn.synthetic_population import Population.This is mostly due to the amount of other parts of the code that are loaded.
This brings the loading down from 1870ms to 737ms
Tested with
python -X importtime -c "from posydon.popsyn.synthetic_population import Population"The imports are still not great. Part of this seems to be how much we import from other parts of posydon.
For example, posydon.popsyn.synthetic_population imports
popsyn.binarypopulation, andposydon.binary_evol.binarystar,etc, which is quite a large "time sink". See the attached image for the import time usage.Focus on the top-left of the below images. These show what is taking the longest to import.
original import time:
importtime from this rework.
