This repository was archived by the owner on Jun 23, 2023. It is now read-only.
add playlist and auto-start#4
Open
develop-branch-2020 wants to merge 1 commit intoPRNDcompany:mainfrom
Open
Conversation
ted-prnd
suggested changes
Dec 4, 2020
| wasRestored: Boolean | ||
| ) { | ||
| if (!wasRestored) { | ||
| if (autoStart) { |
Contributor
There was a problem hiding this comment.
play(), playList()의 코드가 하는일이 똑같고 loadVideo()/cueVideo() or loadPlaylist()/cuePlaylist()만 다릅니다.
이를 처리하는 action을 함수 parameter로 받아서 처리하는 방식으로 개선해주세요
play(), playList() functions is almost same
That functions different only loadVideo()/cueVideo() or loadPlaylist()/cuePlaylist()
Change function parameter for action
There was a problem hiding this comment.
안녕하세요 이 라이브러리를 말씀하신대로 수정하려고 하는데 이 파일이 read-only로 되어있는데 말씀하신대로 수정하려면 코드를 복붙해서 제가 새로운 라이브러리를 만들면 되나요? 초보적인 질문 죄송합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add playlist and auto-start