Skip to content

fix: re-enable pre-commit in devcontainer #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prql-bot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: re-enable pre-commit in devcontainer #5779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c21758c
fix: re-enable pre-commit in devcontainer
prql-bot Apr 7, 2026
a665e9e
fix: remove nonexistent `task install-pre-commit` from devcontainer
prql-bot Apr 7, 2026
555a20a
fix: use `uv tool install pre-commit` instead of install-hooks
prql-bot Apr 7, 2026
16eacb4
ci: add devcontainer CI test using devcontainers/ci
prql-bot Apr 8, 2026
6d695a7
fix: install uv before tasks that depend on it
prql-bot Apr 8, 2026
c8489d0
fix: use pipx to install uv (PEP 668 externally-managed-environment)
prql-bot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@
],
"postCreateCommand": {
"set-ownership": "sudo chown vscode target /usr/local/cargo/registry/",
"install-python-deps": "task install-maturin",
// Disabling because of the issues in #3709
// "install-python-deps": "task install-maturin && task install-pre-commit && pre-commit install-hooks",
"install-python-deps": "pipx install uv && task install-maturin && uv tool install pre-commit",
"install-npm-dependencies": "task install-npm-dependencies"
}
}
20 changes: 20 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
- Taskfile.yaml
devcontainer-build:
- .devcontainer/**/*Dockerfile
- .devcontainer/devcontainer.json
- .github/workflows/build-devcontainer.yaml
- Taskfile.yaml
grammars:
Expand Down Expand Up @@ -546,6 +547,23 @@ jobs:
# This needs to compare to the string `'true'`, because of GHA awkwardness
push: ${{ needs.rules.outputs.devcontainer-push == 'true' }}

test-devcontainer:
runs-on: ubuntu-24.04
needs: rules
if: needs.rules.outputs.devcontainer-build == 'true'
timeout-minutes: 30
steps:
- uses: actions/checkout@v5
- name: Build and run devcontainer
uses: devcontainers/ci@v0.3
with:
runCmd: |
set -euxo pipefail
task --version
pre-commit --version
cargo --version
node --version

test-msrv:
runs-on: ubuntu-24.04
needs: rules
Expand Down Expand Up @@ -601,6 +619,7 @@ jobs:
needs:
- build-devcontainer
- build-web
- test-devcontainer
- check-links-book
- check-links-markdown
- lint-megalinter
Expand Down Expand Up @@ -646,6 +665,7 @@ jobs:
[
"build-devcontainer",
"build-web",
"test-devcontainer",
"check-links-book",
"check-links-markdown",
"lint-megalinter",
Expand Down
Loading