fix: correct Annotate display, fix typos, update stale docs#5792
Open
fix: correct Annotate display, fix typos, update stale docs#5792
Conversation
- Fix Annotate token Display impl: render as `@` not `@{` (matches
the comment on lr.rs:53 and the lexer in mod.rs:169)
- Fix typo in transforms.rs: "much" -> "must"
- Update lezer README: remove stale 2022-12 claim, acknowledge
existing test/ directory
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Annotatedisplay string inprqlc/prqlc-parser/src/lexer/lr.rs: TheTokenKind::Annotatevariant'sDisplayimpl rendered as@{but the token represents a bare@character (as documented in the comment on line 53:Annotate, // @and as lexed inmod.rs:169). This would cause incorrect error messages when the@token appeared in diagnostics.Fix typo in
transforms.rsatprqlc/prqlc/src/semantic/resolver/transforms.rsline 945: Changed "it much point to an input" to "it must point to an input".Update stale lezer README in
grammars/prql-lezer/README.md: Removed a 2022-12 claim ("none yet use it") that was over 3 years old. Updated the Developing section to acknowledge the 11 existing test files intest/instead of claiming there are no tests.Test plan
cargo test -p prqlc-parser -p prqlc --libpasses (all 159 tests)@{so no snapshot updates needed🤖 Generated with Claude Code