Use the new API to access nodes and adjacency matrix#147
Closed
blegat wants to merge 2 commits into
Closed
Conversation
blegat
force-pushed
the
nodes_adj
branch
2 times, most recently
from
822ff51 to
06be9fd
Compare
Member
|
Looks good to me, thanks for the PR---we'll probably want to do the refactor you mentioned down the line, but this should fix the problem for now. |
Contributor
|
I don't agree with this PR, and it currently requires an unreleased branch of MOI. Can we convert this PR to a draft? |
Contributor
Author
|
Sure, it's more appropriate as a draft. It's more of a POC that EAGO continues to work if we merge jump-dev/MathOptInterface.jl#2750 |
Contributor
|
This can be closed. We're not going to break EAGO for the sake of refactoring the innards of MOI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that we broke EAGO when changing internal fields in
jump-dev/MathOptInterface.jl#2747
Ideally, EAGO shouldn't access internal fields are they are not guaranteed to not change so jump-dev/MathOptInterface.jl#2750 adds a public API allowing EAGO to be refactored as done in this PR to stop using internal fields.
You might also be able to refactor further to avoid using
_FunctionStorageand_SubexpressionStoragein the type signatures.Requires