Add import/export of dataclasses to hdf5-based mrp files#766
Open
fzimmermann89 wants to merge 12 commits intomainfrom
Open
Add import/export of dataclasses to hdf5-based mrp files#766fzimmermann89 wants to merge 12 commits intomainfrom
fzimmermann89 wants to merge 12 commits intomainfrom
Conversation
fzimmermann89
added a commit
that referenced
this pull request
Apr 4, 2025
This was referenced Apr 4, 2025
Closed
Closed
Closed
Contributor
fzimmermann89
added a commit
that referenced
this pull request
Apr 4, 2025
fzimmermann89
added a commit
that referenced
this pull request
Apr 4, 2025
fzimmermann89
added a commit
that referenced
this pull request
Apr 4, 2025
fzimmermann89
added a commit
that referenced
this pull request
Apr 11, 2025
fzimmermann89
added a commit
that referenced
this pull request
Apr 11, 2025
fzimmermann89
added a commit
that referenced
this pull request
Apr 11, 2025
fzimmermann89
added a commit
that referenced
this pull request
Apr 11, 2025
9fade86 to
1b01c55
Compare
Contributor
📚 Documentation |
335f9cd to
967ea6a
Compare
Member
Author
|
@ckolbPTB I would like to add this to one of the example notebooks. Then if we break something and the mrp import does not work anymore with the old mrp file, we notice and would have to update the file on zenodo. unit test here would then just do kdata->mrp>kdata roundtrip. Maybe we can have a short notebook about indexing, rearranging, moving to cuda, importing and exporting data? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft of a more efficient "mrpro native" data format matching our dataclass structure.
So instead of acquisitions as in ismrmrd, we write kdata.data, kdata.traj, etc as h5 groups.
This allows us to only store what we actually need in reduced form, speeds up loading for use in trainings and will allow us to store additional information not in ismrmrd.
The idea is to use this for temporary storage and caching. So one can load in all ismrmrd fileds required for a training, dump them to a temp drive and load randomly back into memory in a data loader..