Conversation
Merged
fzimmermann89
approved these changes
Apr 16, 2026
Member
There was a problem hiding this comment.
consider using utils.interpolate.interp #983 (once you reviewed it...) instead of np.interp
and maybe fftfreq
815f01c to
148fc3a
Compare
148fc3a to
5132aeb
Compare
Member
Member
|
I added two small fixes to interp that I missed in #983. I am considering to have them as a seperate PR... ? |
Collaborator
Author
|
@fzimmermann89 great, thanks! Feel free to open a separate PR for the interp changes or just merge it here. Both is fine by me. |
Member
|
Then I am lazy and we keep the interp changes here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs:
Closes #164