Skip to content

Example for MCIR#790

Merged
ckolbPTB merged 210 commits intomainfrom
resp_tv_example
Apr 21, 2026
Merged

Example for MCIR#790
ckolbPTB merged 210 commits intomainfrom
resp_tv_example

Conversation

@ckolbPTB
Copy link
Copy Markdown
Collaborator

@ckolbPTB ckolbPTB commented Apr 26, 2025

Comment thread examples/scripts/motion_corrected_reconstruction.py Outdated
Comment thread examples/scripts/motion_corrected_reconstruction.py Outdated
Copy link
Copy Markdown
Member

@fzimmermann89 fzimmermann89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Comment thread examples/scripts/motion_corrected_reconstruction.py Outdated
@ckolbPTB ckolbPTB requested a review from fzimmermann89 April 16, 2026 20:20
@fzimmermann89 fzimmermann89 mentioned this pull request Apr 16, 2026
Copy link
Copy Markdown
Member

@fzimmermann89 fzimmermann89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using utils.interpolate.interp #983 (once you reviewed it...) instead of np.interp
and maybe fftfreq

Comment thread examples/scripts/motion_corrected_reconstruction.py Outdated
@fzimmermann89 fzimmermann89 moved this from Backlog to In review in next release Apr 17, 2026
@fzimmermann89 fzimmermann89 added the pre-commit.ci autofix run autofix in this PR label Apr 20, 2026
@pre-commit-ci pre-commit-ci Bot removed the pre-commit.ci autofix run autofix in this PR label Apr 20, 2026
@fzimmermann89
Copy link
Copy Markdown
Member

fzimmermann89 commented Apr 20, 2026

I did a small cleanup 5132aeb pass:

  • switch to interp (lets see if that works)
  • use same import style as the other examples
  • prefer .abs(), .mean() etc over torch.abs(), torch.mean() in some places
  • typos

@ckolbPTB is that ok with you?

@fzimmermann89
Copy link
Copy Markdown
Member

I added two small fixes to interp that I missed in #983. I am considering to have them as a seperate PR... ?

@ckolbPTB
Copy link
Copy Markdown
Collaborator Author

@fzimmermann89 great, thanks! Feel free to open a separate PR for the interp changes or just merge it here. Both is fine by me.

@fzimmermann89
Copy link
Copy Markdown
Member

Then I am lazy and we keep the interp changes here

@ckolbPTB ckolbPTB merged commit 6387008 into main Apr 21, 2026
25 checks passed
@ckolbPTB ckolbPTB deleted the resp_tv_example branch April 21, 2026 10:24
@github-project-automation github-project-automation Bot moved this from In review to Done in next release Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Motion corrected image reconstruction

5 participants