Add PEX signal model#841
Draft
fzimmermann89 wants to merge 12 commits intomainfrom
Draft
Conversation
Contributor
Contributor
📚 Documentation |
75fa4d4 to
62a4701
Compare
Member
Author
|
i removred the example script for now and only keep the pex signal model. i moved t1 to the forward. this allows it tbe be inuded in a dictionary for dcitionary matching. |
mxlutz
reviewed
Jul 31, 2025
Collaborator
mxlutz
left a comment
There was a problem hiding this comment.
Looks good, I renamed a to b1 (as it basically is b1...) and changed the dimension of prep_delay, about this I am not sure whether it is a good idea
| """ | ||
| ndim = b1.ndim | ||
| voltages = unsqueeze_right(self.voltages, ndim - self.voltages.ndim + 1) # +1 are voltages | ||
| prep_delay = unsqueeze_right(self.prep_delay, ndim - self.prep_delay.ndim + 1) |
Collaborator
There was a problem hiding this comment.
For me the test_pex_t1_recovery Test was failing due to dimension issues in the signal function (prep_delay and t1 are arrays). This is fixed with moving this to the same dimension as voltages, however I am not sure whether this is a good idea? Usually one of them should only be scalar, could add some assert statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.