Fix mmol/l value when native value of the app is set to mg/dl#49
Merged
Conversation
Turns out that the .value returned from the api is not always in mmol/l as assumed. Instead it seems to be the native value that the libre app is set to. So we calculate the mmol/l ourselves from the fixed mg/dl value provided
Add app_uom property and update get_mmol_l_value method to handle unit of measurement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that the .value returned from the api is not always in mmol/l as assumed. Instead it seems to be the native value that the libre app is set to.
So we calculate the mmol/l ourselves from the fixed mg/dl value provided
Should fix #48