Fix value_mmol_l returning mg/dL value when app native unit is mg/dL#50
Merged
Fix value_mmol_l returning mg/dL value when app native unit is mg/dL#50
Conversation
Co-authored-by: PTST <17211264+PTST@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect value_mmol_l representation in glucose readings
Fix value_mmol_l returning mg/dL value when app native unit is mg/dL
Feb 20, 2026
PTST
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the LibreView app's native unit is set to mg/dL,
value_mmol_lincorrectly reported the raw mg/dL reading instead of converting it to mmol/L (e.g.184instead of~10.22).Root cause
Typo in
get_mmol_l_value:self.gcm_value_in_mg_per_dl(non-existent attribute) instead ofself.gcm.value_in_mg_per_dl.Changes
sensor.py: Fix typo inget_mmol_l_value—self.gcm_value_in_mg_per_dl→self.gcm.value_in_mg_per_dl. Whenapp_uom == 1(mg/dL), mmol/L is now correctly derived from the always-in-mg/dLvalue_in_mg_per_dlfield divided by18.0.manifest.json: Bump version1.0.0→1.1.6to match release tag.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.