Modify canvas update to round newWidth and newHeight to nearest integer#140
Open
tindleroot wants to merge 1 commit intoPWNAGERobotics:mainfrom
Open
Modify canvas update to round newWidth and newHeight to nearest integer#140tindleroot wants to merge 1 commit intoPWNAGERobotics:mainfrom
tindleroot wants to merge 1 commit intoPWNAGERobotics:mainfrom
Conversation
…er to prevent canvas shrink
Author
|
Note: original bug was detected (and fix tested) on Chrome (Windows desktop) and Chrome (mobile/Android) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUGFIX]
Issue: When clickable image (e.g. field image for auto/teleop shot locations) is updated after click, the canvas width and height are recalculated incorrectly, leading to canvas shrinking over many presses.
Bug explanation: The canvas width and height are integers, but the calculated width and height are not (due to ratio between image size and canvas size being non-integer). Therefore, on every update the dimension that is slightly larger shrinks by 1 pixel due to the (fractional) new size being truncated down to integer.
Fix: By rounding the new values to nearest integer, the canvas no longer shrinks on update, but the original intended behavior of recalculating the aspect ratio based on the image is left intact.