Skip to content

fix: update activityInput struct to make ActorID omitempty and simpli… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pikann merged 2 commits into from
May 12, 2026
Merged

fix: update activityInput struct to make ActorID omitempty and simpli… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15c6e3c
fix: update activityInput struct to make ActorID omitempty and simpli…
pikann May 12, 2026
853ee77
fix: add comment to clarify purpose of hostError struct in native_bac…
pikann May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions native_backends.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ func RecordActivity(_, _, _, _ string, _ any) {}

// ptrOf and hostError are used by wasm_backends.go (wasip1 only); provide
// stubs here so the non-WASM build does not need them.
//
//nolint:unused // used in wasm_backends.go in WASM builds
type hostError struct{ msg string }

Expand Down
11 changes: 3 additions & 8 deletions wasm_backends.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func EmitEvent(topic string, payload any) {
type activityInput struct {
TaskID string `json:"task_id"`
ProjectID string `json:"project_id"`
ActorID string `json:"actor_id"`
ActorID string `json:"actor_id,omitempty"`
ActivityType string `json:"activity_type"`
Content any `json:"content"`
}
Expand All @@ -202,13 +202,8 @@ func RecordActivity(taskID, projectID, actorUserID, activityType string, content
ActivityType: activityType,
Content: content,
}
payloadBytes, err := json.Marshal(inp)
if err != nil {
return
}
if !hostActivityRecord(int64(ptrOf(payloadBytes)), int64(len(payloadBytes))) {
return
}
payloadBytes, _ := json.Marshal(inp)
hostActivityRecord(int64(ptrOf(payloadBytes)), int64(len(payloadBytes)))
}

// ── Helpers ───────────────────────────────────────────────────────────────────
Expand Down
Loading