Skip to content

builds on PAL + rudimentary support for FG#9

Open
purpuroptery wants to merge 21 commits intoPackProject:mainfrom
purpuroptery:dgl
Open

builds on PAL + rudimentary support for FG#9
purpuroptery wants to merge 21 commits intoPackProject:mainfrom
purpuroptery:dgl

Conversation

@purpuroptery
Copy link
Contributor

  • works on PAL now
  • did the bare minimum possible so that you can select hole and wind in FG. i didn't change the menus or anything, the golf specific options are still there

@kiwi515
Copy link
Member

kiwi515 commented Jan 10, 2026

just realized the mapfile path changes per region. youll want to open the right file in main, otherwise u cant see symbol names in the exception handler:

    // Open symbol map
+#ifdef CADDIE_REGION_NTSC_U
    MapFile::GetInstance().LoadFromDVD("modules/main_NTSC_U.map",
                                       MapFile::LINK_DYNAMIC);
+#elif CADDIE_REGION_PAL
+   MapFile::GetInstance().LoadFromDVD("modules/main_PAL.map",
+                                      MapFile::LINK_DYNAMIC);
+#endif

@kiwi515
Copy link
Member

kiwi515 commented Jan 10, 2026

pause crash can be fixed by adding this check to the start of MenuMgr::Calc:

if (mMenu == NULL || mOpenPage == NULL) {
    return;
}

didnt realize but it was introduced when i added that strcmp for the post-menu.
however rather than changing that logic i think its better to skip all of Calc when we know theres no menu open anyways

sFlags__9RPGlfBall=0x806fdfbc

# Sports2/Glf/RPGlfPlayerManager
sInstance__18RPGlfPlayerManager=0x806f5b58
Copy link
Member

@kiwi515 kiwi515 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPGlfPlayerManager::sInstance is actually at 0x806f5b08 PAL
fixing the address fixes the B-MINUS-2 crash

there are a lot of singleton classes that do the same CreateInstance pattern so it can be hard to distinguish but u can get a good idea by looking at the size allocated by operator_new

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@purpuroptery
Copy link
Contributor Author

purpuroptery commented Jan 20, 2026

just realized the mapfile path changes per region. youll want to open the right file in main, otherwise u cant see symbol names in the exception handler:

true, adding

pause crash can be fixed by adding this check to the start of MenuMgr::Calc:

if (mMenu == NULL || mOpenPage == NULL) {
    return;
}

ok, adding

// Always show exception handler
static const u16 scEmptyCombo[] = {0};
EGG::Exception::setUserCallback(scEmptyCombo);
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could u move this below the MapFile stuff?
we dont want to waste memory loading the symbol map if we arent building the debug target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants