Skip to content

[CI] Fix missing trailing newlines in approval messages#78422

Merged
SigureMo merged 1 commit intoPaddlePaddle:developfrom
ShigureNyako:fix/approval-check-output-format
Mar 22, 2026
Merged

[CI] Fix missing trailing newlines in approval messages#78422
SigureMo merged 1 commit intoPaddlePaddle:developfrom
ShigureNyako:fix/approval-check-output-format

Conversation

@ShigureNyako
Copy link
Copy Markdown
Contributor

@ShigureNyako ShigureNyako commented Mar 22, 2026

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

This PR keeps the fix scoped to the approval-message definitions themselves instead of changing the shared message assembly logic.

I did a full scan of ci/check_approval.sh and found several rule messages whose echo_line text did not end with a trailing \n. When two such rules are hit consecutively, the later message can be rendered on the same line as the previous one in the final approval-check output.

This patch adds missing trailing \n to the affected approval messages, including the originally observed CHINESE_CHECK case.

The original failure pattern can be seen directly in the approval job log of PR #77938 (run 23396553389, job 68060756583):

2026-03-22T05:32:19.1129870Z 1. Not recommended to use Chinese. You must have one RD (swgu98 or zhangbo9674 or risemeup1) approval.2. You must have one RD (jiahy0825, zyfncg, YuanRisheng or heavyrain-lzy) approval for including "gflags/gflags.h" or "glog/logging.h" headerfile in paddle/phi headerfiles( paddle/phi/api/include/compat/torch/library.h). Recommend including third party headers in phi source files(*.cc) instead of phi headerfiles(*.h). Because if phi headerfiles include third party headers like "gflags.h" or "logging.h", error might occur when outside developers use phi headerfiles directly.
2026-03-22T05:32:19.1134098Z 3. You must have one RD (jiahy0825, zyfncg) or PM (sunzhongkai588, Ligoml) approval for code changes about PADDLE_API. If you add a new PADDLE_API, please make sure you have written detailed comments about the parameter and usage of this PADDLE_API .
2026-03-22T05:32:19.1135102Z There are 4 approved errors.
2026-03-22T05:32:19.1145259Z ##[error]Process completed with exit code 6.

I also re-ran ci/check_approval.sh locally against PR #77938's head diff after applying this patch; the same approval failures are still reported and the script still exits with code 6, but the adjacent items are rendered on separate lines.

This patch only fixes message formatting. It does not change approval matching or the final pass/fail decision.

是否引起精度变化

@paddle-bot
Copy link
Copy Markdown

paddle-bot bot commented Mar 22, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 22, 2026
Copy link
Copy Markdown
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有问题的应该是个例,怎么在这里进行修改?

@ShigureNyako ShigureNyako force-pushed the fix/approval-check-output-format branch from 10ffbb9 to c7ed3a7 Compare March 22, 2026 06:32
@ShigureNyako ShigureNyako changed the title [CI] Fix approval check message formatting [CI] Fix missing newline in Chinese approval message Mar 22, 2026
@ShigureNyako
Copy link
Copy Markdown
Contributor Author

有问题的应该是个例,怎么在这里进行修改?

已按这个方向收窄:撤回了通用拼接逻辑修改,现在只给 ci/check_approval.sh 里的 CHINESE_CHECK 分支补了末尾 \n

复验方式:我用 PR #77938 的 head diff 复放了 ci/check_approval.sh,修复前输出里是:

1. Not recommended to use Chinese. ... approval.2. You must have one RD ...

修复后变成两条独立输出:

1. Not recommended to use Chinese. ... approval.
2. You must have one RD ...

There are 4 approved errors. 和最终 exit 6 保持不变,所以这个提交只修正展示问题,不改变 approval 判断逻辑。

Copy link
Copy Markdown
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外扫一下全量的吧,看看别的有没有问题

Co-authored-by: Nyakku Shigure <38436475+SigureMo@users.noreply.github.com>
@ShigureNyako ShigureNyako force-pushed the fix/approval-check-output-format branch from c7ed3a7 to 29febf6 Compare March 22, 2026 06:40
@ShigureNyako ShigureNyako changed the title [CI] Fix missing newline in Chinese approval message [CI] Fix missing trailing newlines in approval messages Mar 22, 2026
@ShigureNyako
Copy link
Copy Markdown
Contributor Author

另外扫一下全量的吧,看看别的有没有问题

已按这个方向做了 full scan,并保持修法仍然落在具体规则消息本身,没有再回到通用拼接逻辑。

这轮除了 CHINESE_CHECK 之外,还把其余缺少 trailing \n 的 approval message 一起补齐了,包含:

  • HAS_OPERATORBASE_FLAG
  • ShareDataWith / ShareBufferWith
  • -Wno-error
  • RUN_TYPE
  • malloc / new
  • unity_build_rule.cmake
  • BIGTENSOR_CHANGED

验证方式:我把当前 ci/check_approval.sh 放回 PR #77938 的 head diff 上复放,修复前的连行问题可以复现;修复后相邻命中项已正确分行,同时 There are 4 approved errors. 和最终 exit 6 保持不变。

@SigureMo SigureMo merged commit c2b4c53 into PaddlePaddle:develop Mar 22, 2026
208 of 258 checks passed
@SigureMo SigureMo deleted the fix/approval-check-output-format branch March 22, 2026 07:25
@SigureMo SigureMo added Agent and removed contributor External developers labels Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants