[CI] Fix missing trailing newlines in approval messages#78422
Merged
SigureMo merged 1 commit intoPaddlePaddle:developfrom Mar 22, 2026
Merged
[CI] Fix missing trailing newlines in approval messages#78422SigureMo merged 1 commit intoPaddlePaddle:developfrom
SigureMo merged 1 commit intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
10ffbb9 to
c7ed3a7
Compare
Contributor
Author
已按这个方向收窄:撤回了通用拼接逻辑修改,现在只给 复验方式:我用 PR #77938 的 head diff 复放了 修复后变成两条独立输出:
|
Co-authored-by: Nyakku Shigure <38436475+SigureMo@users.noreply.github.com>
c7ed3a7 to
29febf6
Compare
Contributor
Author
已按这个方向做了 full scan,并保持修法仍然落在具体规则消息本身,没有再回到通用拼接逻辑。 这轮除了
验证方式:我把当前 |
SigureMo
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
This PR keeps the fix scoped to the approval-message definitions themselves instead of changing the shared message assembly logic.
I did a full scan of
ci/check_approval.shand found several rule messages whoseecho_linetext did not end with a trailing\n. When two such rules are hit consecutively, the later message can be rendered on the same line as the previous one in the final approval-check output.This patch adds missing trailing
\nto the affected approval messages, including the originally observedCHINESE_CHECKcase.The original failure pattern can be seen directly in the approval job log of PR #77938 (
run 23396553389,job 68060756583):I also re-ran
ci/check_approval.shlocally against PR #77938's head diff after applying this patch; the same approval failures are still reported and the script still exits with code6, but the adjacent items are rendered on separate lines.This patch only fixes message formatting. It does not change approval matching or the final pass/fail decision.
是否引起精度变化
否