Skip to content

Conversation

@adambaumeister
Copy link
Collaborator

This PR enables vsys handling for logical routers.

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like logical routers were added in PAN-OS 10.2...?

If that's the case, then the code for this needs to reflect that. You can refer to this code to see how to add a param for something that only started existing in a particular version:

https://github.com/PaloAltoNetworks/pan-os-python/blob/develop/panos/network.py#L155-L165

@adambaumeister
Copy link
Collaborator Author

@shinmog I added this, I think i got it right? In this way the parameter is excluded for PANOS < 10.2.0, but otherwise it is included. I initially thought I could just add a param with the version already specified but I see this has different behavior.

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was Google's AI that said PAN-OS 10.2. I'd just ask that you verify that as true, but otherwise the code looks spot on, so I'll approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical Routers should be attachable to Vsys objects

3 participants