Add tests against python (WIP)#4
Open
spebern wants to merge 2 commits intoPanieriLorenzo:mainfrom
Open
Conversation
Owner
|
I think it's a good approach, since I'm loosely basing this crate on NumPy and SciPy. I don't have any issues with the python dev dependency as I'm quite comfortable with python. I haven't run it yet because I'll be quite busy for a few days but I'll run it when I have time and tell you if there's any issue. |
Owner
|
I tried running it but it cannot find |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a WIP, and I'd like to get some feedback on this approach first.
Given that a lot of the functionality is available in Python and widely tested, I think it would make sense to test against Python. This can save a lot of time in generating/writing test code, and we profit from the widely tested Python libraries.
Currently, I only added one test for the reverse bessel roots and limited the
nbecause for highernthetry_n_rootswas returning an error.If Python is not available, the test function does not get called, any error on importing SciPy will be ignored, and the test gets skipped.
What do you think about this approach? One disadvantage is that python with SciPy is required for those tests, but I think it makes writing tests so trivial that it is worth introducing it.