-
Notifications
You must be signed in to change notification settings - Fork 67
feat: jsonrpc tool call card #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9625b9a
add jsonrpc tool call card
Junyi-99 26c8c59
Update webapp/_webapp/src/components/message-entry-container/tools/js…
Junyi-99 4fdd38f
Update webapp/_webapp/src/components/message-entry-container/tools/to…
Junyi-99 f0f4342
Update webapp/_webapp/src/index.css
Junyi-99 7208e15
fix: type validator
Junyi-99 6d3d79b
Merge branch 'feat-frontend-jsonrpc' of https://github.com/PaperDebug…
Junyi-99 cab0003
chore: remove console.log
Junyi-99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
73 changes: 73 additions & 0 deletions
73
webapp/_webapp/src/components/message-entry-container/tools/jsonrpc.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { cn } from "@heroui/react"; | ||
| import { JsonRpcResult } from "./utils/common"; | ||
| import MarkdownComponent from "../../markdown"; | ||
| import { LoadingIndicator } from "../../loading-indicator"; | ||
| import { useState } from "react"; | ||
|
|
||
| type JsonRpcProps = { | ||
| functionName: string; | ||
| jsonRpcResult: JsonRpcResult; | ||
| preparing: boolean; | ||
| animated: boolean; | ||
| }; | ||
|
|
||
| export const JsonRpc = ({ functionName, jsonRpcResult, preparing, animated }: JsonRpcProps) => { | ||
| const [isCollapsed, setIsCollapsed] = useState(false); | ||
|
|
||
| if (preparing) { | ||
| return ( | ||
| <div className={cn("tool-card", { animated: animated })}> | ||
| <div className="flex items-center justify-between"> | ||
| <h3 className="tool-card-title tool-card-jsonrpc">{functionName}</h3> | ||
| </div> | ||
| <LoadingIndicator text="Processing ..." estimatedSeconds={300} /> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| const toggleCollapse = () => { | ||
| setIsCollapsed(!isCollapsed); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className={cn("tool-card noselect narrow", { animated: animated })}> | ||
| <div className="flex items-center justify-between cursor-pointer" onClick={toggleCollapse}> | ||
| <h3 className="tool-card-title tool-card-jsonrpc">{functionName}</h3> | ||
| <button | ||
| className="text-gray-400 hover:text-gray-600 transition-colors duration-200 p-1 rounded" | ||
| aria-label={isCollapsed ? "Expand" : "Collapse"} | ||
| > | ||
| <svg | ||
| className={cn("w-4 h-4 transition-transform duration-200", { | ||
| "rotate-180": !isCollapsed | ||
| })} | ||
| fill="none" | ||
| stroke="currentColor" | ||
| viewBox="0 0 24 24" | ||
| > | ||
| <path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M19 9l-7 7-7-7" /> | ||
| </svg> | ||
| </button> | ||
| </div> | ||
|
|
||
| <div className={cn("canselect overflow-hidden transition-all duration-300 ease-in-out", { | ||
| "max-h-0 opacity-0": isCollapsed, | ||
| "max-h-[1000px] opacity-100": !isCollapsed | ||
| })}> | ||
| {jsonRpcResult.result && ( | ||
| <div className="text-xs"> | ||
| <MarkdownComponent animated={animated}> | ||
| {jsonRpcResult.result.content?.map((content) => content.text).join("\n") || ""} | ||
| </MarkdownComponent> | ||
| </div> | ||
| )} | ||
|
|
||
| {jsonRpcResult.error && ( | ||
| <div className="text-xs text-red-600"> | ||
| {jsonRpcResult.error.message} | ||
| </div> | ||
| )} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
webapp/_webapp/src/components/message-entry-container/tools/unknown-jsonrpc.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { cn } from "@heroui/react"; | ||
|
|
||
| type UnknownJsonRpcProps = { | ||
| functionName: string; | ||
| message: string; | ||
| animated: boolean; | ||
| }; | ||
|
|
||
| export const UnknownJsonRpc = ({ functionName, message, animated }: UnknownJsonRpcProps) => { | ||
| return ( | ||
| <div className={cn("tool-card", { animated: animated })}> | ||
| <h3 className="text-xs font-semibold font-sans text-primary-700 uppercase tracking-wider mb-1"> | ||
| Unknown JsonRPC "{functionName}" | ||
| </h3> | ||
| <span className="text-xs text-primary-600">{message}</span> | ||
| </div> | ||
| ); | ||
| }; |
83 changes: 83 additions & 0 deletions
83
webapp/_webapp/src/components/message-entry-container/tools/utils/common.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| export type JsonRpcResult = { | ||
| jsonrpc: string; | ||
| id: number; | ||
| result?: { | ||
| content: Array<{ | ||
| type: string; | ||
| text: string; | ||
| }>; | ||
| }; | ||
| error?: { | ||
| code: number; | ||
| message: string; | ||
| } | ||
| } | ||
|
|
||
| export const UNKNOWN_JSONRPC_RESULT: JsonRpcResult = { | ||
| jsonrpc: "2.0", | ||
| id: -1, | ||
| error: { | ||
| code: -1, | ||
| message: "Unknown JSONRPC result", | ||
| }, | ||
| } | ||
|
|
||
| const isValidJsonRpcResult = (obj: any): obj is JsonRpcResult => { | ||
| // Check if obj is an object and not null | ||
| if (typeof obj !== 'object' || obj === null) { | ||
| return false; | ||
| } | ||
|
|
||
| // Check required properties | ||
| if (typeof obj.jsonrpc !== 'string' || typeof obj.id !== 'number') { | ||
| return false; | ||
| } | ||
|
|
||
| // Check that either result or error is present (but not both required) | ||
| const hasResult = obj.result !== undefined; | ||
| const hasError = obj.error !== undefined; | ||
|
|
||
| // Validate result structure if present | ||
| if (hasResult) { | ||
| if (typeof obj.result !== 'object' || obj.result === null) { | ||
| return false; | ||
| } | ||
| if (obj.result.content !== undefined) { | ||
| if (!Array.isArray(obj.result.content)) { | ||
| return false; | ||
| } | ||
| // Validate each content item | ||
| for (const item of obj.result.content) { | ||
| if (typeof item !== 'object' || item === null || | ||
| typeof item.type !== 'string' || typeof item.text !== 'string') { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Validate error structure if present | ||
| if (hasError) { | ||
| if (typeof obj.error !== 'object' || obj.error === null || | ||
| typeof obj.error.code !== 'number' || typeof obj.error.message !== 'string') { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| }; | ||
|
|
||
| export const parseJsonRpcResult = (message: string): JsonRpcResult | undefined => { | ||
| try { | ||
| const json = JSON.parse(message); | ||
|
|
||
| // Validate the structure before casting | ||
| if (isValidJsonRpcResult(json)) { | ||
| return json; | ||
| } | ||
|
|
||
| return undefined; | ||
| } catch (error) { | ||
| return undefined; | ||
| } | ||
| } | ||
|
Comment on lines
+70
to
+83
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.