Skip to content

fix: Hostname#13

Merged
4ndrelim merged 4 commits intomainfrom
fix-xtramcp-hostname
Nov 3, 2025
Merged

fix: Hostname#13
4ndrelim merged 4 commits intomainfrom
fix-xtramcp-hostname

Conversation

@4ndrelim
Copy link
Member

Key Changes:

  1. Fix hostname for XtraMCP
  2. Minor refactoring - abstracting parsing of SSE response from MCP

@4ndrelim 4ndrelim requested review from Junyi-99 and Copilot October 28, 2025 16:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the hostname configuration for XtraMCP and refactors SSE response parsing by extracting it into a reusable helper function. The changes improve code maintainability by eliminating duplicated parsing logic across multiple files.

Key Changes:

  • Updated XtraMCP hostname from localhost to production URL
  • Extracted SSE response parsing into a shared helper function to eliminate code duplication

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
internal/services/toolkit/tools/xtramcp/tool.go Refactored to use shared parseSSEResponse helper function
internal/services/toolkit/tools/xtramcp/loader.go Refactored to use shared parseSSEResponse helper function
internal/services/toolkit/tools/xtramcp/helper.go Added new parseSSEResponse helper function for SSE format parsing
internal/services/toolkit/client/client.go Updated XtraMCP base URL from localhost to production hostname

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Junyi-99 Junyi-99 changed the title Fix Hostname fix: Hostname Oct 28, 2025
@Junyi-99
Copy link
Member

Hi @4ndrelim, thanks for the pr, please fix the copilot suggestions, then we can merge. :)

@4ndrelim 4ndrelim requested a review from Copilot October 28, 2025 16:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Junyi-99 Junyi-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @4ndrelim , please change https to http. Everything else looks good.

@Junyi-99 Junyi-99 self-requested a review November 2, 2025 16:54
@4ndrelim 4ndrelim merged commit 0e04158 into main Nov 3, 2025
1 check passed
@4ndrelim 4ndrelim deleted the fix-xtramcp-hostname branch November 3, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants