Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the "insert" button in the text patches component was always disabled after sending a message. The root cause was that the clearSelection() function was clearing the selectionRange, which is needed for the insert button to be enabled.
Changes:
- Modified the selection clearing logic in the submit handler to preserve
selectionRangewhen onlyselectedTextexists - Removed "bun" from TypeScript types configuration and added test file exclusions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webapp/_webapp/tsconfig.app.json | Removed "bun" type reference and added test file exclusions |
| webapp/_webapp/src/views/chat/footer/index.tsx | Modified submit handler to conditionally clear selection state, preserving selectionRange for the insert button |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description:
The "insert" button is always disabled because we cleared the selectedText and selectionRange.
Note
Fixes selection handling in chat input and tightens TS config.
PromptInput,submit()now conditionally clears selection: ifselectedTextexists, callsetSelectedText(null)andsetSurroundingText(null); otherwise useclear(). Added corresponding store getters and updateduseCallbackdepstsconfig.app.jsonremovesbunfromtypesand excludes**/*.test.ts(x)from the app buildWritten by Cursor Bugbot for commit 124531c. This will update automatically on new commits. Configure here.