Closed
Conversation
4ndrelim
requested changes
Jan 24, 2026
Member
Author
|
Sure, I'll get it done tmr 25/01 |
Merged
Member
Author
|
@4ndrelim Updated my fix based on your suggested changes! The deeper root cause of this bug is that in Edit: This is the same issue as #99. Either this PR or #100 (which debugs #99) can be used to solve the problem. On hindsight, #100 is probably a more native fix. |
…se eg gpt-5-mini could match to gpt-5
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Prod breaks when user provides their own API key.
Cause of Problem
This is because endpoint, API key and model name are hardcoded to be OpenRouter compatible in some methods.
Solution
This PR fixes this breakage by making the definition of endpoint, API key and model name conditional on whether user specifies their own API key.
Notes to Reviewers
Pls help to test this PR's compatibility with OpenRouter API. I only tested it with OpenAI API as I only have OpenAI API key.