Skip to content

Allow WorldCreator to pass custom environment key - #12922

Open
Doc94 wants to merge 1 commit into
PaperMC:mainfrom
Doc94:feature/world-creator-custom-environment
Open

Allow WorldCreator to pass custom environment key#12922
Doc94 wants to merge 1 commit into
PaperMC:mainfrom
Doc94:feature/world-creator-custom-environment

Conversation

@Doc94

@Doc94 Doc94 commented Aug 3, 2025

Copy link
Copy Markdown
Member

This PR add a new field for WorldCreator called customEnvironmentKey for allow pass a key for dimension_type (LevelStem) for use when the environment its CUSTOM.

This allow for example add a datapack like https://modrinth.com/datapack/islands-overworld-dimension?version=26.1.2 and in a Plugin create a world using that dimension with.

Key environmentKey = Key.key("floating_islands"); // the key of the environment in datapack
WorldCreator worldCreator = new WorldCreator(new NamespacedKey("doc", "floating_islands")).customEnvironmentKey(environmentKey);

World world = plugin.getServer().createWorld(worldCreator);

@Doc94
Doc94 requested a review from a team as a code owner August 3, 2025 16:43
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Aug 3, 2025
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/CraftServer.java Outdated
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/CraftServer.java Outdated
@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch from 18d4ef9 to c9e8b10 Compare December 20, 2025 13:08
@iambibi

iambibi commented Dec 20, 2025

Copy link
Copy Markdown

Why does it say: Status: Awaiting review when one has already been done?

@Doc94

Doc94 commented Apr 27, 2026

Copy link
Copy Markdown
Member Author

Part of this PR was handle in the 26.1 update, the part for call a custom enviroment not sure how handle...
can wait for any moment where this #12119 can revive or just add a custom NamespaceKey in WorldCreator for pass the key of "LevelStem" and use that in case the enviroment is CUSTOM...

@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch from c9e8b10 to aa48b77 Compare April 27, 2026 12:54
@Doc94 Doc94 changed the title Allow WorldCreator to use key to find dimension with CUSTOM environment Allow WorldCreator to pass custom environment key Apr 27, 2026
@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch from aa48b77 to dd93016 Compare April 27, 2026 13:00
@Doc94

Doc94 commented Apr 27, 2026

Copy link
Copy Markdown
Member Author

I modify this PR again for handle the last 26.1 updates, now the PR focus in just allow pass a custom key for being used when the environment is CUSTOM, if #12119 comes alive in the future can just deprecate the whole Environment in favor of LevelStem

@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch from dd93016 to eb93587 Compare April 27, 2026 13:02
Comment thread paper-api/src/main/java/org/bukkit/WorldCreator.java Outdated
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/CraftServer.java Outdated
@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch 2 times, most recently from c3c9b63 to da90d59 Compare April 30, 2026 18:43
@Lulu13022002
Lulu13022002 force-pushed the feature/world-creator-custom-environment branch 2 times, most recently from 08506f0 to 854f901 Compare May 1, 2026 17:49
@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch 2 times, most recently from 5c1c7ba to ce4bd58 Compare May 11, 2026 13:27
@Doc94

Doc94 commented May 11, 2026

Copy link
Copy Markdown
Member Author

@Lulu13022002 i add a way to expose the environment key for use in the copy of WorldCreator... if its better wait for the other PR for expose that info then you can rollback this change... but i feel this PR is ready for the first goal about create worlds with custom environments.

@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch from ce4bd58 to 2939599 Compare June 29, 2026 14:23
@Doc94
Doc94 requested a review from Lulu13022002 June 29, 2026 14:23
Co-authored-by: Lulu13022002 <41980282+Lulu13022002@users.noreply.github.com>
@Doc94
Doc94 force-pushed the feature/world-creator-custom-environment branch from 2939599 to 6038142 Compare July 18, 2026 13:19
@Doc94

Doc94 commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

Rebased for handle the rebuild in 1c67f14

@Lulu13022002 Lulu13022002 added the status: blocked Issue or Request is waiting on some other issue or change. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: blocked Issue or Request is waiting on some other issue or change.

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

4 participants