Clear scoreboard team entries on unregister - #14159
Open
Foorcee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unregistering a scoreboard team removes its entries from the scoreboard's internal mappings, but the entries remain stored in the old team instance.
This leaves the unregistered team in an inconsistent state. Calling
hasEntryon that instance can still returntrue, even though the entry is no longer assigned to that team in the scoreboard.For example:
The call to
removeEntryfails with:This happens because
t1still contains"Notch"in its internal player list, while the scoreboard no longer considers the player to be part of that team.Changes
Clear the team's player collection when the team is unregistered.
This ensures that an unregistered team instance accurately reflects its state and prevents stale entries from causing
IllegalStateExceptions when the instance is referenced afterwards.