Validate lootables refresh-max is not below refresh-min - #14166
Closed
chirag-gamer wants to merge 1 commit into
Closed
Validate lootables refresh-max is not below refresh-min#14166chirag-gamer wants to merge 1 commit into
chirag-gamer wants to merge 1 commit into
Conversation
github-project-automation
Bot
moved this from Awaiting review
to Closed
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lootables.refresh-minandlootables.refresh-maxwere never checked against each other. Withrefresh-maxbelowrefresh-min,PaperLootableInventoryData#shouldClearLootTablecomputesRANDOM.nextLong(max - min + 1)with a non-positive bound, which throwsIllegalArgumentException: bound must be positivethe first time a lootable container is cleared. I verified that throw with a small program (new Random().nextLong(0)throws).Fixes #14165
Added a
@PostProcessvalidation on theLootablesconfig part, the same patternprecomputeDespawnDistancesuses. It rejectsrefresh-max < refresh-minwith a clear message at config load, so the mistake fails loudly at startup instead of at the first chest.Compiles against the full server. I didn't add a unit test because this runs through the world config loading path, which needs the Minecraft registries to be present; happy to add one if there's a pattern for it.