Skip to content

Fixes a Bunch of RCL Bugs#31698

Merged
PollardTheDragon merged 17 commits intoParadiseSS13:masterfrom
CRUNCH-Borg:RCL-Cable
Apr 9, 2026
Merged

Fixes a Bunch of RCL Bugs#31698
PollardTheDragon merged 17 commits intoParadiseSS13:masterfrom
CRUNCH-Borg:RCL-Cable

Conversation

@CRUNCH-Borg
Copy link
Copy Markdown
Contributor

@CRUNCH-Borg CRUNCH-Borg commented Feb 24, 2026

What Does This PR Do

Converts the RCL into a cable subtype. This brings the immedite benefits of fixing several bugs where systems expect a cable coil and will reject the RCL before it can pass the attack chain off to the cable coil.

This also fixes any bug caused by the internal cable coil escaping the confines of the RCL, or the internal cable coil failing to spawn on Initialize(), both of which can cause lots of runtimes and/or brick the RCL permanently.

Why It's Good For The Game

Fixing multiple bugs is good.

Testing

Laid cable. Picked cable up with RCL. Tried to mix cables.
Used cables for machine building. Put RCL on tables and shelves.
Used RCL for surgery.
Tried to perform exploits, failed.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixed multiple RCL bugs.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added Map Edit This PR will modify a map -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 24, 2026
Comment thread code/modules/power/cables/cable_coil.dm Outdated
Comment thread code/game/turfs/turf.dm Outdated
@github-actions
Copy link
Copy Markdown
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions Bot added the Stale This PR has been left inactive and requires an update. label Mar 11, 2026
@github-actions github-actions Bot removed the Stale This PR has been left inactive and requires an update. label Mar 16, 2026
@github-actions github-actions Bot added the Merge Conflict This PR is merge conflicted label Apr 2, 2026
@PollardTheDragon PollardTheDragon added Fix This PR will fix an issue in the game Code Improvement This PR will improve the code quality of the codebase labels Apr 2, 2026
@CRUNCH-Borg CRUNCH-Borg requested a review from Contrabang April 2, 2026 22:12
@github-actions github-actions Bot removed the Merge Conflict This PR is merge conflicted label Apr 3, 2026
@CRUNCH-Borg CRUNCH-Borg changed the title Fixes a Bunch of RCL Bugs, Makes Rainbow Cables More Rainbowy, Migrates Cables to the New Attack Chain Fixes a Bunch of RCL Bugs Apr 3, 2026
@github-actions github-actions Bot added the Merge Conflict This PR is merge conflicted label Apr 7, 2026
Copy link
Copy Markdown
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending merge conflict resolution.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Apr 7, 2026
Signed-off-by: CRUNCH <143041327+CRUNCH-Borg@users.noreply.github.com>
@PollardTheDragon PollardTheDragon added this pull request to the merge queue Apr 9, 2026
Merged via the queue into ParadiseSS13:master with commit 05eeff6 Apr 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-Status: Awaiting merge This PR is ready for merge Code Improvement This PR will improve the code quality of the codebase Fix This PR will fix an issue in the game Map Edit This PR will modify a map Merge Conflict This PR is merge conflicted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants