Migrates /obj/item/stack to the new attack chain#31709
Merged
PollardTheDragon merged 15 commits intoParadiseSS13:masterfrom Apr 2, 2026
Merged
Migrates /obj/item/stack to the new attack chain#31709PollardTheDragon merged 15 commits intoParadiseSS13:masterfrom
/obj/item/stack to the new attack chain#31709PollardTheDragon merged 15 commits intoParadiseSS13:masterfrom
Conversation
warriorstar-orion
approved these changes
Mar 4, 2026
Contributor
warriorstar-orion
left a comment
There was a problem hiding this comment.
Code LGTM, should still be TMed for a day or two since lots of interactions are affected.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Migrates
/obj/item/stackto the new attack chain.Changes the failure hints for applying goliath plates to borgs and wires to glass tiles to be more descriptive.
Synthetic skin plates are no longer consumed if you fail to apply them.
This should probably be put on TM because it's another big one and something might break.
Why It's Good For The Game
Attack chain migration good.
Hints should tell you stuff.
You shouldn't use stuff that you fail to use.
Testing
Made sure stacks didn't merge between each other.
Wired glass
Wirecutted wired glass tiles.
Pressed telecrystals into uplinks.
Punched skrell and bandaged and splinted them.
Burned skrell and slathered ointment on them.
Screwed about with cables a whole bunch.
Applied various kinds of armour plating to mecha.
Applied skin patches to some robots.
Made leather from hide.
Made sure ore bag pickup still works (all modes).
Declaration
Changelog
🆑
tweak: Made failure hints on applying goliath plates to borgs more descriptive.
tweak: Made failure hints on wiring wired glass tiles more descriptive.
fix: Synthetic skin plates are no longer consumed if you fail to apply them.
/:cl: