Skip to content

Migrates /obj/item/stack to the new attack chain#31709

Merged
PollardTheDragon merged 15 commits intoParadiseSS13:masterfrom
CRUNCH-Borg:Stack-attack-chain-migration
Apr 2, 2026
Merged

Migrates /obj/item/stack to the new attack chain#31709
PollardTheDragon merged 15 commits intoParadiseSS13:masterfrom
CRUNCH-Borg:Stack-attack-chain-migration

Conversation

@CRUNCH-Borg
Copy link
Copy Markdown
Contributor

@CRUNCH-Borg CRUNCH-Borg commented Mar 1, 2026

What Does This PR Do

Migrates /obj/item/stack to the new attack chain.

Changes the failure hints for applying goliath plates to borgs and wires to glass tiles to be more descriptive.

Synthetic skin plates are no longer consumed if you fail to apply them.

This should probably be put on TM because it's another big one and something might break.

Why It's Good For The Game

Attack chain migration good.
Hints should tell you stuff.
You shouldn't use stuff that you fail to use.

Testing

Made sure stacks didn't merge between each other.
Wired glass
Wirecutted wired glass tiles.
Pressed telecrystals into uplinks.
Punched skrell and bandaged and splinted them.
Burned skrell and slathered ointment on them.
Screwed about with cables a whole bunch.
Applied various kinds of armour plating to mecha.
Applied skin patches to some robots.
Made leather from hide.
Made sure ore bag pickup still works (all modes).

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Made failure hints on applying goliath plates to borgs more descriptive.
tweak: Made failure hints on wiring wired glass tiles more descriptive.
fix: Synthetic skin plates are no longer consumed if you fail to apply them.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Mar 2, 2026
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Mar 3, 2026
@warriorstar-orion warriorstar-orion added Refactor This PR will clean up the code but have the same ingame outcome Attack Chain Migration Refactoring of legacy attack chain items labels Mar 4, 2026
Copy link
Copy Markdown
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, should still be TMed for a day or two since lots of interactions are affected.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Mar 4, 2026
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Mar 18, 2026
@PollardTheDragon PollardTheDragon added this pull request to the merge queue Apr 2, 2026
Merged via the queue into ParadiseSS13:master with commit d030b8a Apr 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-Status: Awaiting merge This PR is ready for merge Attack Chain Migration Refactoring of legacy attack chain items Refactor This PR will clean up the code but have the same ingame outcome Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants