π‘οΈ Sentinel: Fix Stored XSS in Theme Profile Name #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix Stored XSS in Theme Profiles
π¨ Severity: HIGH
π‘ Vulnerability: Stored Cross-Site Scripting (XSS) in Theme Profile Name
π― Impact: An attacker (or compromised account) could create a theme profile with a malicious name (e.g.,
<img src=x onerror=alert(1)>). This script would execute in the browser of any user who views the list of theme profiles, potentially leading to session hijacking or unauthorized actions.π§ Fix: Refactored
createProfileCardinsrc/main/webui/static/features/layout-theme.tsto assign the profile name usingtextContentinstead of interpolating it directly intoinnerHTML.β Verification: Verified code logic ensures that
profile.nameis now treated as plain text and not parsed as HTML. TypeScript build check was attempted but skipped due to environment limitations (private dependencies), but the change is type-safe and standard DOM API usage.PR created automatically by Jules for task 11879142753233894181 started by @GhostTypes