Skip to content

Conversation

@GhostTypes
Copy link
Member

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix Stored XSS in Theme Profiles

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Stored Cross-Site Scripting (XSS) in Theme Profile Name
🎯 Impact: An attacker (or compromised account) could create a theme profile with a malicious name (e.g., <img src=x onerror=alert(1)>). This script would execute in the browser of any user who views the list of theme profiles, potentially leading to session hijacking or unauthorized actions.
πŸ”§ Fix: Refactored createProfileCard in src/main/webui/static/features/layout-theme.ts to assign the profile name using textContent instead of interpolating it directly into innerHTML.
βœ… Verification: Verified code logic ensures that profile.name is now treated as plain text and not parsed as HTML. TypeScript build check was attempted but skipped due to environment limitations (private dependencies), but the change is type-safe and standard DOM API usage.


PR created automatically by Jules for task 11879142753233894181 started by @GhostTypes

- refactor `createProfileCard` to use `textContent` instead of `innerHTML` for profile name
- prevents malicious scripts from executing when viewing theme profiles
- journal security finding in `.jules/sentinel.md`

Co-authored-by: GhostTypes <106415648+GhostTypes@users.noreply.github.com>
@google-labs-jules
Copy link

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants