Fixes and Improvements #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix EnvironmentService to properly detect pkg-bundled binaries using multiple detection methods (PKG_EXECPATH, snapshot path, process.pkg) - Update WebUIManager to use EnvironmentService for static path resolution instead of hardcoded process.cwd(), fixing "/Get error" on binary builds - Add SPA fallback route to serve index.html for client-side routing - Add explicit 404 handlers for API routes and missing static files - Update README with comprehensive installation instructions including: - Pre-built binary download table with platform guidance - Clear instructions for Raspberry Pi users (ARM64 vs ARMv7) - Corrected "Running from Source" instructions - Command line options documentation - Troubleshooting section for common issues - Bump version to 1.0.2
- Remove misleading assumption that users downloaded wrong architecture - Correctly identify the issue as a static file serving bug fixed in 1.0.2 - Move platform selection guidance to separate reference section - Simplify Raspberry Pi note
- Update project status from "not fully tested" to "production-ready" - Remove Windows-specific path reference that was not relevant to users - Update Testing Notes section to reflect what has been verified working - Reorganize remaining testing areas as "continued testing" items - Remove FlashForgeUI-Electron from Related Projects (internal reference)
- Add Usage section explaining how to access WebUI (localhost:3000) - Document default password (changeme) and how to change it - Replace JSON config block with clearer settings table - Add descriptions for all configuration options - Rename Development section to Building from Source - Add comments for each platform build command - Remove redundant dev server instructions (already in Running from Source)
GhostTypes
changed the title
Implement complete test coverage for core functionality: - EnvironmentService: Package detection, path resolution, environment state (23 tests) - ConfigManager: Configuration loading, updates, validation, events (23 tests) - Error utilities: All error codes, factories, handlers, serialization (68 tests) - WebUIManager integration: Static files, API routes, SPA routing, middleware (24 tests) Test infrastructure: - Configure Jest 30.2.0 with ts-jest and ESM preset - Add supertest for HTTP integration testing - Implement Express 5.x compatible routing tests - Add test scripts: test, test:watch, test:coverage, test:verbose All 118 tests passing (100% pass rate) across 4 test suites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.