Performance: Using a dict for ParticleSet._data (instead of xarray DataSet)#2094
Merged
erikvansebille merged 5 commits intov4-devfrom Jul 22, 2025
Merged
Performance: Using a dict for ParticleSet._data (instead of xarray DataSet)#2094erikvansebille merged 5 commits intov4-devfrom
erikvansebille merged 5 commits intov4-devfrom
Conversation
This was referenced Jul 21, 2025
VeckoTheGecko
approved these changes
Jul 22, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good to me. This will be further fleshed out once we look at particlefile outputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
ParticleSet._datato be a dictionary of numpy arrays, instead of the xarray Dataset implemented in #2079. This gives a major performance boost (see Parcels-code/parcels-benchmarks#1)mainfor v3 changes,v4-devfor v4 changes)