Using float for time in the Parcels kernel#2117
Closed
erikvansebille wants to merge 4 commits intov4-devfrom
Closed
Using float for time in the Parcels kernel#2117erikvansebille wants to merge 4 commits intov4-devfrom
erikvansebille wants to merge 4 commits intov4-devfrom
Conversation
As performance tests have shown that this is approx 50% faster
1 task
Member
Author
|
Note that in this PR< we still assume that the user inputs |
VeckoTheGecko
requested changes
Jul 28, 2025
Small correctness fix. Otherwise could have run into edge cases with multiple fields defined on different (yet compatible) calendars.
VeckoTheGecko
approved these changes
Jul 29, 2025
Member
Author
|
We're not pursuing this anymore; getting good performance with numpy.datetime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts to using float inside the kernel (as in v3), as performance tests have shown that this is approx 50% faster. See e.g. Parcels-code/parcels-benchmarks#1 (comment)
mainfor v3 changes,v4-devfor v4 changes)