Draft
Conversation
… be used to release particles in a grid cell rather than at a T-point
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 15.43% 15.33% -0.10%
==========================================
Files 6 6
Lines 473 476 +3
==========================================
Hits 73 73
- Misses 400 403 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR that changes the way we initialise particles, rather than one particle at the T-point of a grid cell, we will initialise n particles randomly within a grid cell.
create_release_maps.pyfile is working as expectedcreate_particleset_from_map()function inconstructorsto use the grid cellsPoint 2 above is non-trivial, as we want to randomly distribute particle across the grid cell. Trivial for a rectilinear grid, but non-trivial for our curvilinear grid. Possible approach is to perform a rotation (like the Jacobian approach in the interpolation scheme?)